Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 717283002: Service Workers: Remove overloads for optional Dictionary arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerGlobalScope.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
index b0de04517c21f77d87f41ac675f24a8f69fbda9e..c1f32ff67bc18f8be442dc956bf97a142badcf8b 100644
--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
@@ -99,22 +99,6 @@ CacheStorage* ServiceWorkerGlobalScope::caches(ExecutionContext* context)
return m_caches;
}
-ScriptPromise ServiceWorkerGlobalScope::fetch(ScriptState* scriptState, Request* request)
-{
- if (!m_fetchManager)
- return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "ServiceWorkerGlobalScope is shutting down."));
- // "Let |r| be the associated request of the result of invoking the initial
- // value of Request as constructor with |input| and |init| as arguments. If
- // this throws an exception, reject |p| with it."
- TrackExceptionState exceptionState;
- Request* r = Request::create(this, request, exceptionState);
- if (exceptionState.hadException()) {
- // FIXME: We should throw the caught error.
- return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), exceptionState.message()));
- }
- return m_fetchManager->fetch(scriptState, r->request());
-}
-
ScriptPromise ServiceWorkerGlobalScope::fetch(ScriptState* scriptState, Request* request, const Dictionary& requestInit)
{
if (!m_fetchManager)
@@ -131,22 +115,6 @@ ScriptPromise ServiceWorkerGlobalScope::fetch(ScriptState* scriptState, Request*
return m_fetchManager->fetch(scriptState, r->request());
}
-ScriptPromise ServiceWorkerGlobalScope::fetch(ScriptState* scriptState, const String& urlstring)
-{
- if (!m_fetchManager)
- return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "ServiceWorkerGlobalScope is shutting down."));
- // "Let |r| be the associated request of the result of invoking the initial
- // value of Request as constructor with |input| and |init| as arguments. If
- // this throws an exception, reject |p| with it."
- TrackExceptionState exceptionState;
- Request* r = Request::create(this, urlstring, exceptionState);
- if (exceptionState.hadException()) {
- // FIXME: We should throw the caught error.
- return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), exceptionState.message()));
- }
- return m_fetchManager->fetch(scriptState, r->request());
-}
-
ScriptPromise ServiceWorkerGlobalScope::fetch(ScriptState* scriptState, const String& urlstring, const Dictionary& requestInit)
{
if (!m_fetchManager)
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerGlobalScope.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698