Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 717263004: Remove implicit conversions from scoped_refptr to T* in components/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang, mef
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in components/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/58d219ec9112c692fecde412963f0b45b7b7fd6b Cr-Commit-Position: refs/heads/master@{#304046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M components/storage_monitor/portable_device_watcher_win.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M components/wifi/wifi_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
+mef for components/wifi, +thestig for components/storage_monitor.
6 years, 1 month ago (2014-11-12 23:07:17 UTC) #2
Lei Zhang
lgtm
6 years, 1 month ago (2014-11-12 23:09:28 UTC) #3
mef
lgtm
6 years, 1 month ago (2014-11-13 17:11:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717263004/1
6 years, 1 month ago (2014-11-13 17:18:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 18:05:39 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 18:06:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58d219ec9112c692fecde412963f0b45b7b7fd6b
Cr-Commit-Position: refs/heads/master@{#304046}

Powered by Google App Engine
This is Rietveld 408576698