Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: extensions/browser/api/socket/udp_socket.cc

Issue 717263003: Use uint16 for port numbers, extensions/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/socket/udp_socket.cc
diff --git a/extensions/browser/api/socket/udp_socket.cc b/extensions/browser/api/socket/udp_socket.cc
index 50da3e23d86abeb9fd489695ce50c67be88035dc..d8f3eae3f4a74cf33b65767d1ab5d081c5e8eac0 100644
--- a/extensions/browser/api/socket/udp_socket.cc
+++ b/extensions/browser/api/socket/udp_socket.cc
@@ -36,7 +36,7 @@ UDPSocket::UDPSocket(const std::string& owner_extension_id)
UDPSocket::~UDPSocket() { Disconnect(); }
void UDPSocket::Connect(const std::string& address,
- int port,
+ uint16 port,
const CompletionCallback& callback) {
int result = net::ERR_CONNECTION_FAILED;
do {
@@ -56,7 +56,7 @@ void UDPSocket::Connect(const std::string& address,
callback.Run(result);
}
-int UDPSocket::Bind(const std::string& address, int port) {
+int UDPSocket::Bind(const std::string& address, uint16 port) {
if (IsBound())
return net::ERR_CONNECTION_FAILED;
@@ -163,7 +163,7 @@ void UDPSocket::RecvFrom(int count,
void UDPSocket::SendTo(scoped_refptr<net::IOBuffer> io_buffer,
int byte_count,
const std::string& address,
- int port,
+ uint16 port,
const CompletionCallback& callback) {
DCHECK(!callback.is_null());
@@ -224,7 +224,7 @@ void UDPSocket::OnRecvFromComplete(scoped_refptr<net::IOBuffer> io_buffer,
int result) {
DCHECK(!recv_from_callback_.is_null());
std::string ip;
- int port = 0;
+ uint16 port = 0;
if (result > 0 && address.get()) {
IPEndPointToStringAndPort(address->data, &ip, &port);
}

Powered by Google App Engine
This is Rietveld 408576698