Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: extensions/browser/api/socket/socket.cc

Issue 717263003: Use uint16 for port numbers, extensions/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/socket/socket.cc
diff --git a/extensions/browser/api/socket/socket.cc b/extensions/browser/api/socket/socket.cc
index afec38f46df44c8c79b5cd82f1d12f9a561fdfe4..bf701fc761a87367776bb72717b828caec57cf32 100644
--- a/extensions/browser/api/socket/socket.cc
+++ b/extensions/browser/api/socket/socket.cc
@@ -90,7 +90,7 @@ bool Socket::SetKeepAlive(bool enable, int delay) { return false; }
bool Socket::SetNoDelay(bool no_delay) { return false; }
int Socket::Listen(const std::string& address,
- int port,
+ uint16 port,
int backlog,
std::string* error_msg) {
*error_msg = kSocketTypeNotSupported;
@@ -103,7 +103,7 @@ void Socket::Accept(const AcceptCompletionCallback& callback) {
// static
bool Socket::StringAndPortToIPEndPoint(const std::string& ip_address_str,
- int port,
+ uint16 port,
net::IPEndPoint* ip_end_point) {
DCHECK(ip_end_point);
net::IPAddressNumber ip_number;
@@ -115,7 +115,7 @@ bool Socket::StringAndPortToIPEndPoint(const std::string& ip_address_str,
}
bool Socket::StringAndPortToAddressList(const std::string& ip_address_str,
- int port,
+ uint16 port,
net::AddressList* address_list) {
DCHECK(address_list);
net::IPAddressNumber ip_number;
@@ -128,7 +128,7 @@ bool Socket::StringAndPortToAddressList(const std::string& ip_address_str,
void Socket::IPEndPointToStringAndPort(const net::IPEndPoint& address,
std::string* ip_address_str,
- int* port) {
+ uint16* port) {
DCHECK(ip_address_str);
DCHECK(port);
*ip_address_str = address.ToStringWithoutPort();

Powered by Google App Engine
This is Rietveld 408576698