Factor clip path painting code out of LayerPainter::paintLayerContents into a ClipPathPainter helpe…

Factor clip path painting code out of LayerPainter::paintLayerContents into a ClipPathPainter helper class.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185254

[chrishtr, 2014-11-12 18:25:59]

chrishtr@chromium.org changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2014-11-12 21:00:27]

lgtm with two nits and one suggestion for later.

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
File Source/core/paint/LayerPainter.cpp (right):

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
Source/core/paint/LayerPainter.cpp:161: class ClipPathPainter {
Does this class actually paint anything at all? Could "ClipPathHandler" work?
ClipPathHelper? PathClipper?

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
Source/core/paint/LayerPainter.cpp:165: : m_resourceClipper(0),
m_clipStateSaver(*context, false), m_renderLayer(renderLayer),
m_context(context)
Strange indentation.

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
Source/core/paint/LayerPainter.cpp:183: if (!rootRelativeBoundsComputed) {
It's tempting to create a getter for this (LayoutRect* rootRelativeBounds() or
something), and thus get rid of two parameters to the constructor here, but
better defer that to a follow-up CL.

[chrishtr, 2014-11-12 21:41:45]

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
File Source/core/paint/LayerPainter.cpp (right):

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
Source/core/paint/LayerPainter.cpp:161: class ClipPathPainter {
On 2014/11/12 21:00:27, mstensho wrote:
> Does this class actually paint anything at all? Could "ClipPathHandler" work?
> ClipPathHelper? PathClipper?

Done.

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
Source/core/paint/LayerPainter.cpp:165: : m_resourceClipper(0),
m_clipStateSaver(*context, false), m_renderLayer(renderLayer),
m_context(context)
On 2014/11/12 21:00:27, mstensho wrote:
> Strange indentation.

Done.

https://codereview.chromium.org/717263002/diff/20001/Source/core/paint/LayerP...
Source/core/paint/LayerPainter.cpp:183: if (!rootRelativeBoundsComputed) {
On 2014/11/12 21:00:27, mstensho wrote:
> It's tempting to create a getter for this (LayoutRect* rootRelativeBounds() or
> something), and thus get rid of two parameters to the constructor here, but
> better defer that to a follow-up CL.

I almost pulled the trigger on this in earlier revisions of this CL, but felt it
was too much
complication in the end, because it has to be carefully reset according to a
paint timeline, etc.

Maybe there is a simpler way.

[chrishtr, 2014-11-12 21:41:48]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-11-12 21:42:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/717263002/40001

[commit-bot: I haz the power, 2014-11-12 23:28:28]

Committed patchset #3 (id:40001) as 185254