Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 717233003: Allow app_shell embedders to override extensions client interfaces (Closed)

Created:
6 years, 1 month ago by James Cook
Modified:
6 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow app_shell embedders to override extensions client interfaces This includes ExtensionsClient and ExtensionsBrowserClient. BUG=none TEST=app_shell_unittests Committed: https://crrev.com/4d8d72ef85260841830d4215f0fcfaf9d49fd5b6 Cr-Commit-Position: refs/heads/master@{#304946}

Patch Set 1 #

Patch Set 2 : (extensions-client) typo #

Patch Set 3 : (extensions-client) renderer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M extensions/shell/browser/shell_browser_main_parts.h View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.h View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
James Cook
Dan, PTAL
6 years, 1 month ago (2014-11-19 17:14:03 UTC) #2
James Cook
Actually, wait on this. It might need to be more elaborate.
6 years, 1 month ago (2014-11-19 17:27:32 UTC) #3
James Cook
Dan, PTAL
6 years, 1 month ago (2014-11-19 21:52:23 UTC) #4
Daniel Erat
lgtm
6 years, 1 month ago (2014-11-20 00:06:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717233003/40001
6 years, 1 month ago (2014-11-20 00:08:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 00:49:57 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:51:17 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d8d72ef85260841830d4215f0fcfaf9d49fd5b6
Cr-Commit-Position: refs/heads/master@{#304946}

Powered by Google App Engine
This is Rietveld 408576698