Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 71723003: Remove HistoryPublisher code. (Closed)

Created:
7 years, 1 month ago by Scott Hess - ex-Googler
Modified:
7 years, 1 month ago
CC:
chromium-reviews, browser-components-watch_chromium.org, akalin
Visibility:
Public.

Description

Remove HistoryPublisher code. AFAICT, the last clients of this code no longer depend on it, so get it removed before someone else decides to depend on it. BUG=161116, 294306 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235676

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase to trunk #

Patch Set 3 : Remove ref to history_indexer.idl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -725 lines) Patch
M chrome/browser/history/history_backend.h View 4 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 6 chunks +0 lines, -38 lines 0 comments Download
D chrome/browser/history/history_indexer.idl View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/history/history_publisher.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/history/history_publisher.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/history/history_publisher_none.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/history/history_publisher_win.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M chrome/browser/history/history_service.h View 4 chunks +8 lines, -21 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/history/history_tab_helper.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 2 chunks +0 lines, -29 lines 0 comments Download
D chrome/browser/history/page_collector.h View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/history/page_collector.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M tools/memory_watcher/scripts/summary.pl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Scott Hess - ex-Googler
brettw@ for history/ cevans@ expressed interest in render_messages.h last time. akalin@ just FYI. This is ...
7 years, 1 month ago (2013-11-13 20:55:14 UTC) #1
Chris Evans
On 2013/11/13 20:55:14, shess wrote: > brettw@ for history/ > cevans@ expressed interest in render_messages.h ...
7 years, 1 month ago (2013-11-14 00:13:00 UTC) #2
brettw
lgtm
7 years, 1 month ago (2013-11-14 21:50:18 UTC) #3
Scott Hess - ex-Googler
I see I need another OWNERS: thestig@ for chrome/renderer/chrome_render_view_observer.cc
7 years, 1 month ago (2013-11-14 22:41:32 UTC) #4
Lei Zhang
lgtm stamp
7 years, 1 month ago (2013-11-14 22:47:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/71723003/1
7 years, 1 month ago (2013-11-14 23:50:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/71723003/1
7 years, 1 month ago (2013-11-15 02:26:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/71723003/1
7 years, 1 month ago (2013-11-15 04:21:24 UTC) #8
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=126220
7 years, 1 month ago (2013-11-15 05:33:47 UTC) #9
Lei Zhang
https://codereview.chromium.org/71723003/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/71723003/diff/1/chrome/chrome_browser.gypi#newcode3447 chrome/chrome_browser.gypi:3447: 'browser/history/history_indexer.idl', Remove?
7 years, 1 month ago (2013-11-15 05:35:48 UTC) #10
Scott Hess - ex-Googler
Gave another run-through with git-gs, don't see other refs to deleted files. https://codereview.chromium.org/71723003/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi ...
7 years, 1 month ago (2013-11-15 18:29:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/71723003/510001
7 years, 1 month ago (2013-11-15 18:40:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/71723003/510001
7 years, 1 month ago (2013-11-15 22:25:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/71723003/510001
7 years, 1 month ago (2013-11-16 01:06:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/71723003/510001
7 years, 1 month ago (2013-11-18 01:23:58 UTC) #15
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 08:54:28 UTC) #16
Message was sent while issue was closed. 
Change committed as 235676

Powered by Google App Engine
This is Rietveld 408576698