Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3132)

Unified Diff: chrome/browser/signin/signin_manager.cc

Issue 71723002: This is the second CL of several that will eventually replace TokenService with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_manager.h ('k') | chrome/browser/signin/signin_manager_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager.cc
diff --git a/chrome/browser/signin/signin_manager.cc b/chrome/browser/signin/signin_manager.cc
index 2f8863fdbd3f1fe2d57f32e0ad0ced1777546a87..f1cff13069be546d6c7cf1d8173594be0d877c71 100644
--- a/chrome/browser/signin/signin_manager.cc
+++ b/chrome/browser/signin/signin_manager.cc
@@ -19,13 +19,13 @@
#include "chrome/browser/signin/about_signin_internals.h"
#include "chrome/browser/signin/about_signin_internals_factory.h"
#include "chrome/browser/signin/local_auth.h"
+#include "chrome/browser/signin/profile_oauth2_token_service.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
#include "chrome/browser/signin/signin_global_error.h"
#include "chrome/browser/signin/signin_internals_util.h"
#include "chrome/browser/signin/signin_manager_cookie_helper.h"
#include "chrome/browser/signin/signin_manager_delegate.h"
#include "chrome/browser/signin/signin_manager_factory.h"
-#include "chrome/browser/signin/token_service.h"
-#include "chrome/browser/signin/token_service_factory.h"
#include "chrome/browser/ui/global_error/global_error_service.h"
#include "chrome/browser/ui/global_error/global_error_service_factory.h"
#include "chrome/common/chrome_switches.h"
@@ -120,10 +120,10 @@ SigninManager::~SigninManager() {
}
void SigninManager::InitTokenService() {
- SigninManagerBase::InitTokenService();
- TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
+ ProfileOAuth2TokenService* token_service =
+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile_);
if (token_service && !GetAuthenticatedUsername().empty())
- token_service->LoadTokensFromDB();
+ token_service->LoadCredentials();
}
std::string SigninManager::SigninTypeToString(
@@ -334,14 +334,16 @@ void SigninManager::SignOut() {
chrome::NOTIFICATION_GOOGLE_SIGNED_OUT,
content::Source<Profile>(profile_),
content::Details<const GoogleServiceSignoutDetails>(&details));
- TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
- token_service->ResetCredentialsInMemory();
- token_service->EraseTokensFromDB();
+ ProfileOAuth2TokenService* token_service =
+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile_);
+ token_service->RevokeAllCredentials();
}
void SigninManager::Initialize(Profile* profile, PrefService* local_state) {
SigninManagerBase::Initialize(profile, local_state);
+ InitTokenService();
+
// local_state can be null during unit tests.
if (local_state) {
local_state_pref_registrar_.Init(local_state);
@@ -551,17 +553,13 @@ void SigninManager::CompletePendingSignin() {
DCHECK(!possibly_invalid_username_.empty());
OnSignedIn(possibly_invalid_username_);
- // If we have oauth2 tokens, tell token service about them so it does not
- // need to fetch them again. Its important that the authenticated name has
- // already been set before sending the oauth2 token to the token service.
- // Some token service listeners will query the authenticated name when they
- // receive the token available notification.
- if (!temp_oauth_login_tokens_.refresh_token.empty()) {
- TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
- DCHECK(!GetAuthenticatedUsername().empty());
- token_service->UpdateCredentialsWithOAuth2(temp_oauth_login_tokens_);
- temp_oauth_login_tokens_ = ClientOAuthResult();
- }
+ DCHECK(!temp_oauth_login_tokens_.refresh_token.empty());
+ DCHECK(!GetAuthenticatedUsername().empty());
+ ProfileOAuth2TokenService* token_service =
+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile_);
+ token_service->UpdateCredentials(GetAuthenticatedUsername(),
+ temp_oauth_login_tokens_.refresh_token);
+ temp_oauth_login_tokens_ = ClientOAuthResult();
}
void SigninManager::OnExternalSigninCompleted(const std::string& username) {
« no previous file with comments | « chrome/browser/signin/signin_manager.h ('k') | chrome/browser/signin/signin_manager_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698