Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: components/browser_watcher/watcher_win.cc

Issue 717223002: Browser watcher end-end-to-end . (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/lkgr
Patch Set: Address Erik's comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_watcher/watcher_win.h ('k') | components/browser_watcher/watcher_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/watcher_win.cc
diff --git a/components/browser_watcher/watcher_win.cc b/components/browser_watcher/watcher_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..93e7d6f52bbfeb115822762196057b0912105488
--- /dev/null
+++ b/components/browser_watcher/watcher_win.cc
@@ -0,0 +1,103 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/process/kill.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/stringprintf.h"
+#include "base/win/registry.h"
+#include "components/browser_watcher/watcher_win.h"
+
+namespace browser_watcher {
+
+namespace {
+
+base::string16 GetValueName(const base::Time creation_time,
+ base::ProcessId pid) {
+ // Convert the PID and creation time to a string value unique to this
+ // process instance.
+ return base::StringPrintf(L"%d-%lld", pid, creation_time.ToInternalValue());
+}
+
+} // namespace
+
+ExitCodeWatcher::ExitCodeWatcher(const base::char16* registry_path) :
+ registry_path_(registry_path),
+ process_(base::kNullProcessHandle),
+ process_pid_(0) {
+}
+
+ExitCodeWatcher::~ExitCodeWatcher() {
+}
+
+bool ExitCodeWatcher::ParseArguments(const base::CommandLine& cmd_line) {
+ std::string process_handle_str =
+ cmd_line.GetSwitchValueASCII("parent-handle");
+ unsigned process_handle_uint = 0;
+ if (process_handle_str.empty() ||
+ !base::StringToUint(process_handle_str, &process_handle_uint)) {
+ LOG(ERROR) << "Missing or invalid parent-handle argument.";
+ return false;
+ }
+
+ HANDLE process_handle = reinterpret_cast<HANDLE>(process_handle_uint);
+ // Initial test of the handle, a zero PID indicates invalid handle, or not
+ // a process handle. In this case, bail immediately and avoid closing the
+ // handle.
+ DWORD process_pid = ::GetProcessId(process_handle);
+ if (process_pid == 0) {
+ LOG(ERROR) << "Invalid parent-handle, can't get parent PID.";
+ return false;
+ }
+
+ FILETIME creation_time = {};
+ FILETIME dummy = {};
+ if (!::GetProcessTimes(process_handle, &creation_time,
+ &dummy, &dummy, &dummy)) {
+ LOG(ERROR) << "Invalid parent handle, can't get parent process times.";
+ return false;
+ }
+
+ // Success, take ownership of the process handle.
+ process_.Set(process_handle);
+ process_pid_ = process_pid;
+ process_creation_time_ = base::Time::FromFileTime(creation_time);
+
+ // Start by writing the value STILL_ACTIVE to registry, to allow detection
+ // of the case where the watcher itself is somehow terminated before it can
+ // write the process' actual exit code.
+ base::win::RegKey key(HKEY_CURRENT_USER,
+ registry_path_.c_str(),
+ KEY_WRITE);
+ base::string16 value_name(GetValueName(process_creation_time_, process_pid_));
+
+ ULONG result = key.WriteValue(value_name.c_str(), STILL_ACTIVE);
+ if (result != ERROR_SUCCESS) {
+ LOG(ERROR) << "Unable to write to registry, error " << result;
+ return false;
+ }
+
+ return true;
+}
+
+void ExitCodeWatcher::WaitForExit() {
+ int exit_code = 0;
+ if (!base::WaitForExitCode(process_.Get(), &exit_code)) {
+ LOG(ERROR) << "Failed to wait for process.";
+ return;
+ }
+ // WaitForExitCode closes the handle on success.
+ process_.Take();
+
+ base::win::RegKey key(HKEY_CURRENT_USER,
+ registry_path_.c_str(),
+ KEY_WRITE);
+ base::string16 value_name(GetValueName(process_creation_time_, process_pid_));
+
+ ULONG result = key.WriteValue(value_name.c_str(), exit_code);
+ if (result != ERROR_SUCCESS)
+ LOG(ERROR) << "Unable to write exit code, error: " << result;
+}
+
+} // namespace browser_watcher
« no previous file with comments | « components/browser_watcher/watcher_win.h ('k') | components/browser_watcher/watcher_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698