components/browser_watcher/watcher_main_win.h - Issue 717223002: Browser watcher end-end-to-end .

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/browser_watcher/watcher_main_win.h

Issue 717223002: Browser watcher end-end-to-end . (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/lkgr

Patch Set: Move to components Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/browser_watcher/watcher_client_win.h ('K') | « components/browser_watcher/watcher_client_win_unittest.cc ('k') | components/browser_watcher/watcher_main_win.cc » ('j') | components/browser_watcher/watcher_main_win.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
	erikwright (departed) 2014/11/14 19:46:09 I would rename this file to watcher_main_api_win o I would rename this file to watcher_main_api_win or watcher_main_entrypoint_win or similar. And create a corresponding .cc file that contains the constant definitions. Instead of having them live in some strange, somewhat unrelated file. Sigurður Ásgeirsson 2014/11/17 15:26:58 Done. Show quoted text On 2014/11/14 19:46:09, erikwright wrote: > I would rename this file to watcher_main_api_win or watcher_main_entrypoint_win > or similar. And create a corresponding .cc file that contains the constant > definitions. > > Instead of having them live in some strange, somewhat unrelated file. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_BROWSER_WATCHER_WATCHER_MAIN_WIN_H_

	6 #define COMPONENTS_BROWSER_WATCHER_WATCHER_MAIN_WIN_H_

	7

	8 #include "base/files/file_path.h"

	9

	10 namespace browser_watcher {

	11

	12 // The name of the watcher DLL.

	13 extern const base::FilePath::CharType kWatcherDll[];

	14 // The name of the watcher DLLs entrypoint function.

	15 extern const char kWatcherDLLEntrypoint[];

	16

	17 // The type of the watcher DLL's main entry point.

	18 // The \|registry_path\| parameter is the path under HKCU where the exit

	19 // codes will be written.

	20 typedef int (WatcherMainFunction)(const wchar_t registry_path);

	21

	22 } // namespace browser_watcher

	23

	24 #endif // COMPONENTS_BROWSER_WATCHER_WATCHER_MAIN_WIN_H_

OLD	NEW