Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 717203002: Revert of Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome (Closed)

Created:
6 years, 1 month ago by no longer working on chromium
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, klundberg+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #4 id:60001 of https://codereview.chromium.org/663413002/) Reason for revert: This CL broke the configuration of AudioProcessing, we have to revert it to fix the echo issues it introduces. Original issue's description: > Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome. > > The original review thread is in https://codereview.chromium.org/588523002/ > > Fix the way how we create webrtc::AudioProcessing in Chrome. > > TBR=tommi@chromium.org,maruel@chromium.org > > BUG=415935 > TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist. > > Committed: https://crrev.com/79ef9085fbdbc8e09ac989ea4d5f4c28e516bba9 > Cr-Commit-Position: refs/heads/master@{#300509} TBR=maruel@chromium.org,tommi@chromium.org NOTREECHECKS=true NOTRY=true BUG=415935 Committed: https://crrev.com/515c2beb237eae38347a86f7011b897674496ea2 Cr-Commit-Position: refs/heads/master@{#303834}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : fix build/android/pylib/utils/isolator.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -74 lines) Patch
M build/android/pylib/utils/isolator.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +0 lines, -15 lines 0 comments Download
M content/content_unittests.isolate View 1 2 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 1 4 chunks +1 line, -12 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 1 5 chunks +2 lines, -20 lines 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 1 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
no longer working on chromium
Created Revert of Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome
6 years, 1 month ago (2014-11-12 14:10:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717203002/1
6 years, 1 month ago (2014-11-12 14:11:15 UTC) #2
commit-bot: I haz the power
Failed to apply patch for build/android/pylib/gtest/setup.py: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-11-12 14:11:43 UTC) #4
no longer working on chromium
Tommi, this is the revert CL.
6 years, 1 month ago (2014-11-12 15:03:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717203002/240001
6 years, 1 month ago (2014-11-12 15:04:26 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:240001)
6 years, 1 month ago (2014-11-12 15:05:27 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/515c2beb237eae38347a86f7011b897674496ea2 Cr-Commit-Position: refs/heads/master@{#303834}
6 years, 1 month ago (2014-11-12 15:06:08 UTC) #10
no longer working on chromium
6 years, 1 month ago (2014-11-12 15:25:37 UTC) #12
Message was sent while issue was closed.
+ Bjorn, fyi, this is the revert CL.

Powered by Google App Engine
This is Rietveld 408576698