Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 717193003: HTMLPlugInElement: Use custom focus logic only when there is a plugin. (Closed)

Created:
6 years, 1 month ago by jbroman
Modified:
6 years, 1 month ago
Reviewers:
esprehn, Mike West
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

HTMLPlugInElement: Use custom focus logic only when there is a plugin. This allows focus to enter and leave plugin placeholders, so that constituent elements (such as a close button) can be keyboard-focused. TEST=fast/plugins/plugin/placeholder-focus.html BUG=364716 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
A LayoutTests/fast/plugins/plugin-placeholder-focus.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/plugins/plugin-placeholder-focus-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
6 years, 1 month ago (2014-11-12 21:25:27 UTC) #2
Mike West
LGTM.
6 years, 1 month ago (2014-11-13 10:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717193003/1
6 years, 1 month ago (2014-11-13 14:18:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 185290
6 years, 1 month ago (2014-11-13 14:19:57 UTC) #6
jbroman
6 years, 1 month ago (2014-11-14 18:17:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/729573002/ by jbroman@chromium.org.

The reason for reverting is: probable cause of use-after-free:
https://code.google.com/p/chromium/issues/detail?id=433357.

Powered by Google App Engine
This is Rietveld 408576698