Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: src/compiler.cc

Issue 717143002: Disable top level serialization under harmony_scoping. It has broken tests. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 8
9 #include "src/ast-numbering.h" 9 #include "src/ast-numbering.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 1225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1236 info.SetContext(context); 1236 info.SetContext(context);
1237 if (FLAG_serialize_toplevel && 1237 if (FLAG_serialize_toplevel &&
1238 compile_options == ScriptCompiler::kProduceCodeCache) { 1238 compile_options == ScriptCompiler::kProduceCodeCache) {
1239 info.PrepareForSerializing(); 1239 info.PrepareForSerializing();
1240 } 1240 }
1241 if (FLAG_use_strict) info.SetStrictMode(STRICT); 1241 if (FLAG_use_strict) info.SetStrictMode(STRICT);
1242 1242
1243 result = CompileToplevel(&info); 1243 result = CompileToplevel(&info);
1244 if (extension == NULL && !result.is_null() && !result->dont_cache()) { 1244 if (extension == NULL && !result.is_null() && !result->dont_cache()) {
1245 compilation_cache->PutScript(source, context, result); 1245 compilation_cache->PutScript(source, context, result);
1246 if (FLAG_serialize_toplevel && 1246 // TODO(dslomov): Issue 3628.
1247 // Reenable when harmony scoping serialization issues are fixed.
1248 if (FLAG_serialize_toplevel && !FLAG_harmony_scoping &&
1247 compile_options == ScriptCompiler::kProduceCodeCache) { 1249 compile_options == ScriptCompiler::kProduceCodeCache) {
1248 HistogramTimerScope histogram_timer( 1250 HistogramTimerScope histogram_timer(
1249 isolate->counters()->compile_serialize()); 1251 isolate->counters()->compile_serialize());
1250 *cached_data = CodeSerializer::Serialize(isolate, result, source); 1252 *cached_data = CodeSerializer::Serialize(isolate, result, source);
1251 if (FLAG_profile_deserialization) { 1253 if (FLAG_profile_deserialization) {
1252 PrintF("[Compiling and serializing took %0.3f ms]\n", 1254 PrintF("[Compiling and serializing took %0.3f ms]\n",
1253 timer.Elapsed().InMillisecondsF()); 1255 timer.Elapsed().InMillisecondsF());
1254 } 1256 }
1255 } 1257 }
1256 } 1258 }
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1470 AllowHandleDereference allow_deref; 1472 AllowHandleDereference allow_deref;
1471 bool tracing_on = info()->IsStub() 1473 bool tracing_on = info()->IsStub()
1472 ? FLAG_trace_hydrogen_stubs 1474 ? FLAG_trace_hydrogen_stubs
1473 : (FLAG_trace_hydrogen && 1475 : (FLAG_trace_hydrogen &&
1474 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter)); 1476 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));
1475 return (tracing_on && 1477 return (tracing_on &&
1476 base::OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL); 1478 base::OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
1477 } 1479 }
1478 1480
1479 } } // namespace v8::internal 1481 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698