Only allow background tabs if the underlying input event allows it

Only allow background tabs if the underlying input event allows it

If a page takes clickjacks a regular click, don't allow opening
background tabs from anchor elements.

BUG=431335
TEST=none, content_shell doesn't do tabs...
R=mkwst@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185205

[Mike West, 2014-11-12 12:20:08]

https://codereview.chromium.org/717133002/diff/1/Source/web/FrameLoaderClient...
File Source/web/FrameLoaderClientImpl.cpp (right):

https://codereview.chromium.org/717133002/diff/1/Source/web/FrameLoaderClient...
Source/web/FrameLoaderClientImpl.cpp:465: if (!inputEvent || inputEvent->type !=
WebInputEvent::MouseUp)
Why can we only create a new tab on MouseUp? I mean, I understand that it's
probably less annoying that way, but does this match usage on the web?

(Or does it only match annoying/malicious use on the web? :) )

[jochen (gone - plz use gerrit), 2014-11-12 12:31:34]

On 2014/11/12 at 12:20:08, mkwst wrote:
>
https://codereview.chromium.org/717133002/diff/1/Source/web/FrameLoaderClient...
> File Source/web/FrameLoaderClientImpl.cpp (right):
> 
>
https://codereview.chromium.org/717133002/diff/1/Source/web/FrameLoaderClient...
> Source/web/FrameLoaderClientImpl.cpp:465: if (!inputEvent || inputEvent->type
!= WebInputEvent::MouseUp)
> Why can we only create a new tab on MouseUp? I mean, I understand that it's
probably less annoying that way, but does this match usage on the web?

MouseUp is translated to click, e.g., if you mouse down on a link, but don't
release, nothing happens.

This is basically a copy from updateNavigationPolicy in ChromeClientImpl.cpp

[Mike West, 2014-11-12 12:36:47]

On 2014/11/12 12:31:34, jochen (OOO) wrote:
> On 2014/11/12 at 12:20:08, mkwst wrote:
> >
>
https://codereview.chromium.org/717133002/diff/1/Source/web/FrameLoaderClient...
> > File Source/web/FrameLoaderClientImpl.cpp (right):
> > 
> >
>
https://codereview.chromium.org/717133002/diff/1/Source/web/FrameLoaderClient...
> > Source/web/FrameLoaderClientImpl.cpp:465: if (!inputEvent ||
inputEvent->type
> != WebInputEvent::MouseUp)
> > Why can we only create a new tab on MouseUp? I mean, I understand that it's
> probably less annoying that way, but does this match usage on the web?
> 
> MouseUp is translated to click, e.g., if you mouse down on a link, but don't
> release, nothing happens.

Ah, right. I guess I should have realized that, since I do the "click -> oh no!
-> drag -> release" dance multiple times a day. :)

LGTM.

[jochen (gone - plz use gerrit), 2014-11-12 12:55:37]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-11-12 12:56:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/717133002/1

[commit-bot: I haz the power, 2014-11-12 13:15:05]

Committed patchset #1 (id:1) as 185205

[Stephen White, 2014-11-12 17:05:13]

I'm guessing this change may be causing failures in
PrerenderBrowserTest.PrerenderClickNewBackgroundTab:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

(it's either this change or
http://src.chromium.org/viewvc/blink?revision=185204&view=revision, which looks
unrelated.)

Speculatively reverting.