src/runtime/runtime-generator.cc - Issue 717123002: Leaving a generator via an exception causes it to close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-generator.cc

Issue 717123002: Leaving a generator via an exception causes it to close (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-generator.cc

diff --git a/src/runtime/runtime-generator.cc b/src/runtime/runtime-generator.cc

index 9c2add7413621f7253a4bc912ecf8b0a192ea1c7..071105f784c8b40618f960e79c9d04aced1d4ee1 100644

--- a/src/runtime/runtime-generator.cc

+++ b/src/runtime/runtime-generator.cc

@@ -135,6 +135,17 @@ RUNTIME_FUNCTION(Runtime_ResumeJSGeneratorObject) {

}

+RUNTIME_FUNCTION(Runtime_GeneratorClose) {

+ HandleScope scope(isolate);

+ DCHECK(args.length() == 1);

+ CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator, 0);

+ generator->set_continuation(JSGeneratorObject::kGeneratorClosed);

+ return isolate->heap()->undefined_value();

RUNTIME_FUNCTION(Runtime_ThrowGeneratorStateError) {

HandleScope scope(isolate);

DCHECK(args.length() == 1);