Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 7171021: Reverting this to see if the Flash crashes on Mac canary are due to this CL. (Closed)

Created:
9 years, 6 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
davidben
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Reverting this to see if the Flash crashes on Mac canary are due to this CL. Revert 88773 - Don't retain NPNVWindowNPObject and NPNVPluginElementNPObject twice Both NPN_GetValue and WebPluginProxy take a reference on access, with the latter conflating the caller's reference and its internal reference. To be consistent with WebPluginImpl, let WebPluginProxy only manage its internal reference and leave the plugin's reference to NPN_GetValue. Document this in the WebPlugin interface. Also release plugin-side proxies when WebPluginProxy is destroyed. R=ananta BUG=86124 TEST=none Review URL: http://codereview.chromium.org/6693052 TBR=davidben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M content/plugin/webplugin_proxy.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M webkit/plugins/npapi/webplugin.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
9 years, 6 months ago (2011-06-15 18:24:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698