Chromium Code Reviews

Issue 717093002: Perform receiver patching for sloppy mode in high-level IR. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger
Modified:
6 years, 1 month ago
Reviewers:
Dmitry Lomov (no reviews), *Toon Verwaest, danno
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Perform receiver patching for sloppy mode in high-level IR. R=verwaest@chromium.org TEST=cctest/test-run-jscalls/ReceiverPatching Committed: https://chromium.googlesource.com/v8/v8/+/9e0865069fa53678d24def0f1e7828b5391f11d2

Patch Set 1 #

Patch Set 2 : Remove borked optimization. #

Patch Set 3 : Reintroduce optimization. #

Total comments: 1

Patch Set 4 : Fix TODO comment. #

Patch Set 5 : Minor fix. #

Unified diffs Side-by-side diffs Stats (+56 lines, -92 lines)
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -18 lines 0 comments
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -17 lines 0 comments
M src/compiler/ast-graph-builder.h View 2 chunks +4 lines, -0 lines 0 comments
M src/compiler/ast-graph-builder.cc View 3 chunks +47 lines, -4 lines 0 comments
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -18 lines 0 comments
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -18 lines 0 comments
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -17 lines 0 comments
M src/scopes.cc View 1 chunk +5 lines, -0 lines 0 comments

Messages

Total messages: 7 (3 generated)
Michael Starzinger
Toon: PTAL. Danno: FYI.
6 years, 1 month ago (2014-11-12 11:24:35 UTC) #3
Michael Starzinger
Toon: PTAL. Danno: FYI. Dmitry: FYI (see comment). https://codereview.chromium.org/717093002/diff/40001/src/scopes.cc File src/scopes.cc (right): https://codereview.chromium.org/717093002/diff/40001/src/scopes.cc#newcode376 src/scopes.cc:376: // ...
6 years, 1 month ago (2014-11-12 15:21:55 UTC) #5
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-13 09:41:44 UTC) #6
Michael Starzinger
6 years, 1 month ago (2014-11-13 10:48:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
9e0865069fa53678d24def0f1e7828b5391f11d2 (presubmit successful).

Powered by Google App Engine