Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: content/browser/tracing/trace_message_filter.h

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/trace_message_filter.h
diff --git a/content/browser/tracing/trace_message_filter.h b/content/browser/tracing/trace_message_filter.h
index 3d12d76d300d23f497517afcafa419adcf15511d..4bb3038ca04b0581a31b016a1a4563dd2b9653c0 100644
--- a/content/browser/tracing/trace_message_filter.h
+++ b/content/browser/tracing/trace_message_filter.h
@@ -31,7 +31,7 @@ class TraceMessageFilter : public BrowserMessageFilter {
const base::debug::TraceOptions& options);
void SendDisableMonitoring();
void SendCaptureMonitoringSnapshot();
- void SendGetTraceBufferPercentFull();
+ void SendGetTraceBufferUsage();
void SendSetWatchEvent(const std::string& category_name,
const std::string& event_name);
void SendCancelWatchEvent();
@@ -45,7 +45,7 @@ class TraceMessageFilter : public BrowserMessageFilter {
void OnEndTracingAck(const std::vector<std::string>& known_categories);
void OnCaptureMonitoringSnapshotAcked();
void OnWatchEventMatched();
- void OnTraceBufferPercentFullReply(float percent_full);
+ void OnTraceBufferUsageReply(size_t event_capacity, size_t event_count);
void OnTraceDataCollected(const std::string& data);
void OnMonitoringTraceDataCollected(const std::string& data);
@@ -56,7 +56,7 @@ class TraceMessageFilter : public BrowserMessageFilter {
bool is_awaiting_end_ack_;
// Awaiting ack for previously sent SendCaptureMonitoringSnapshot
bool is_awaiting_capture_monitoring_snapshot_ack_;
- // Awaiting ack for previously sent SendGetTraceBufferPercentFull
+ // Awaiting ack for previously sent SendGetTraceBufferUsage
bool is_awaiting_buffer_percent_full_ack_;
DISALLOW_COPY_AND_ASSIGN(TraceMessageFilter);

Powered by Google App Engine
This is Rietveld 408576698