Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: content/browser/devtools/protocol/tracing_handler.cc

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/tracing_handler.cc
diff --git a/content/browser/devtools/protocol/tracing_handler.cc b/content/browser/devtools/protocol/tracing_handler.cc
index 6e9fa55aa48cce3a0f1cd6cb22c0a734675ee6cd..fe187b84cfc5f5fdc2d00e12d7562bfd2dd9a000 100644
--- a/content/browser/devtools/protocol/tracing_handler.cc
+++ b/content/browser/devtools/protocol/tracing_handler.cc
@@ -142,8 +142,9 @@ void TracingHandler::OnRecordingEnabled(
client_->SendStartResponse(command, StartResponse::Create());
}
-void TracingHandler::OnBufferUsage(float usage) {
- client_->BufferUsage(BufferUsageParams::Create()->set_value(usage));
+void TracingHandler::OnBufferUsage(float percent_full,
+ size_t approximate_event_count) {
+ client_->BufferUsage(BufferUsageParams::Create()->set_value(percent_full));
}
void TracingHandler::OnCategoriesReceived(

Powered by Google App Engine
This is Rietveld 408576698