components/tracing/child_trace_message_filter.cc - Issue 717083003: Report trace buffer usage as number of events, not only percentage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/child_trace_message_filter.cc

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/tracing/child_trace_message_filter.cc

diff --git a/components/tracing/child_trace_message_filter.cc b/components/tracing/child_trace_message_filter.cc

index fe13ff57dd08ca8d7038c7c38ad091bafa18e145..98841225c8b9959d85d2379fed0ed7f72ea394a5 100644

--- a/components/tracing/child_trace_message_filter.cc

+++ b/components/tracing/child_trace_message_filter.cc

@@ -107,8 +107,10 @@ void ChildTraceMessageFilter::OnCaptureMonitoringSnapshot() {

void ChildTraceMessageFilter::OnGetTraceBufferPercentFull() {

float bpf = TraceLog::GetInstance()->GetBufferPercentFull();

+ size_t buffer_usage = TraceLog::GetInstance()->GetBufferUsage();

- sender_->Send(new TracingHostMsg_TraceBufferPercentFullReply(bpf));

+ sender_->Send(

+ new TracingHostMsg_TraceBufferPercentFullReply(bpf, buffer_usage));

}

void ChildTraceMessageFilter::OnSetWatchEvent(const std::string& category_name,

« base/debug/trace_event_impl.h ('K') | « base/debug/trace_event_impl.cc ('k') | components/tracing/tracing_messages.h » ('j') | no next file with comments »