Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Side by Side Diff: content/browser/browser_shutdown_profile_dumper.cc

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_shutdown_profile_dumper.h" 5 #include "content/browser/browser_shutdown_profile_dumper.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/debug/trace_event.h" 9 #include "base/debug/trace_event.h"
10 #include "base/debug/trace_event_impl.h" 10 #include "base/debug/trace_event_impl.h"
(...skipping 11 matching lines...) Expand all
22 const base::FilePath& dump_file_name) 22 const base::FilePath& dump_file_name)
23 : dump_file_name_(dump_file_name), 23 : dump_file_name_(dump_file_name),
24 blocks_(0), 24 blocks_(0),
25 dump_file_(NULL) { 25 dump_file_(NULL) {
26 } 26 }
27 27
28 BrowserShutdownProfileDumper::~BrowserShutdownProfileDumper() { 28 BrowserShutdownProfileDumper::~BrowserShutdownProfileDumper() {
29 WriteTracesToDisc(); 29 WriteTracesToDisc();
30 } 30 }
31 31
32 static float GetTraceBufferPercentFull() {
33 base::debug::TraceLog::BufferUsage buffer_usage =
34 base::debug::TraceLog::GetInstance()->GetBufferUsage();
35 return 100 *
36 static_cast<float>(static_cast<double>(buffer_usage.event_count) /
37 buffer_usage.event_capacity);
38 }
39
32 void BrowserShutdownProfileDumper::WriteTracesToDisc() { 40 void BrowserShutdownProfileDumper::WriteTracesToDisc() {
33 // Note: I have seen a usage of 0.000xx% when dumping - which fits easily. 41 // Note: I have seen a usage of 0.000xx% when dumping - which fits easily.
34 // Since the tracer stops when the trace buffer is filled, we'd rather save 42 // Since the tracer stops when the trace buffer is filled, we'd rather save
35 // what we have than nothing since we might see from the amount of events 43 // what we have than nothing since we might see from the amount of events
36 // that caused the problem. 44 // that caused the problem.
37 DVLOG(1) << "Flushing shutdown traces to disc. The buffer is %" << 45 DVLOG(1) << "Flushing shutdown traces to disc. The buffer is "
38 base::debug::TraceLog::GetInstance()->GetBufferPercentFull() << 46 << GetTraceBufferPercentFull() << "% full.";
39 " full.";
40 DCHECK(!dump_file_); 47 DCHECK(!dump_file_);
41 dump_file_ = base::OpenFile(dump_file_name_, "w+"); 48 dump_file_ = base::OpenFile(dump_file_name_, "w+");
42 if (!IsFileValid()) { 49 if (!IsFileValid()) {
43 LOG(ERROR) << "Failed to open performance trace file: " 50 LOG(ERROR) << "Failed to open performance trace file: "
44 << dump_file_name_.value(); 51 << dump_file_name_.value();
45 return; 52 return;
46 } 53 }
47 WriteString("{\"traceEvents\":"); 54 WriteString("{\"traceEvents\":");
48 WriteString("["); 55 WriteString("[");
49 56
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 } 140 }
134 141
135 void BrowserShutdownProfileDumper::CloseFile() { 142 void BrowserShutdownProfileDumper::CloseFile() {
136 if (!dump_file_) 143 if (!dump_file_)
137 return; 144 return;
138 base::CloseFile(dump_file_); 145 base::CloseFile(dump_file_);
139 dump_file_ = NULL; 146 dump_file_ = NULL;
140 } 147 }
141 148
142 } // namespace content 149 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698