Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 717053002: Revert "Use expected main frame size from WebViewImpl when creating a new FrameView." (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/PinchViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 0452dc008bcf93b5f394ec9f1a05c64fe157da1d..f03c838e0a04c9b0b36a42a555c41f7ebf42067e 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -3210,21 +3210,6 @@ void WebViewImpl::setIgnoreViewportTagScaleLimits(bool ignore)
setUserAgentPageScaleConstraints(constraints);
}
-IntSize WebViewImpl::mainFrameSize() const
-{
- if (!pinchVirtualViewportEnabled())
- return m_size;
-
- FrameView* view = page()->deprecatedLocalMainFrame()->view();
-
- int contentAndScrollbarWidth = contentsSize().width();
-
- if (view && view->verticalScrollbar() && !view->verticalScrollbar()->isOverlayScrollbar())
- contentAndScrollbarWidth += view->verticalScrollbar()->width();
-
- return m_pageScaleConstraintsSet.mainFrameSize(contentAndScrollbarWidth);
-}
-
void WebViewImpl::refreshPageScaleFactorAfterLayout()
{
if (!mainFrame() || !page() || !page()->mainFrame() || !page()->mainFrame()->isLocalFrame() || !page()->deprecatedLocalMainFrame()->view())
@@ -3241,8 +3226,13 @@ void WebViewImpl::refreshPageScaleFactorAfterLayout()
m_pageScaleConstraintsSet.adjustFinalConstraintsToContentsSize(contentsSize(), verticalScrollbarWidth);
}
- if (pinchVirtualViewportEnabled())
- view->resize(mainFrameSize());
+ if (pinchVirtualViewportEnabled()) {
+ int contentAndScrollbarWidth = contentsSize().width();
+ if (view->verticalScrollbar() && !view->verticalScrollbar()->isOverlayScrollbar())
+ contentAndScrollbarWidth += view->verticalScrollbar()->width();
+
+ view->resize(m_pageScaleConstraintsSet.mainFrameSize(contentAndScrollbarWidth));
+ }
float newPageScaleFactor = pageScaleFactor();
if (m_pageScaleConstraintsSet.needsReset() && m_pageScaleConstraintsSet.finalConstraints().initialScale != -1) {
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/PinchViewportTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698