Chromium Code Reviews

Issue 716963002: Remove property-specific handling in animation-test-helpers.js (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
Reviewers:
dstockwell, alancutter (OOO until 2018)
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@animhelpercleanup
Project:
blink
Visibility:
Public.

Description

Remove property-specific handling in animation-test-helpers.js This patch makes animation-test-helpers.js not care about which properties are being tested by always working with strings from computed style directly. The previous behaviour relies heavily on the no longer web-exposed getPropertyCSSValue which we want to delete. Instead of having separate expectation types for different properties, we simply match numeric substrings of the computed style value. The top of the file has a comment explaining in more detail. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185179

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm unneeded expectation; upd comment #

Patch Set 3 : rm whitespace #

Unified diffs Side-by-side diffs Stats (+247 lines, -698 lines)
M LayoutTests/animations/3d/transform-perspective.html View 1 chunk +2 lines, -2 lines 0 comments
M LayoutTests/animations/3d/transform-perspective-expected.txt View 1 chunk +2 lines, -2 lines 0 comments
M LayoutTests/animations/animation-direction-reverse-fill-mode.html View 3 chunks +8 lines, -8 lines 0 comments
M LayoutTests/animations/animation-direction-reverse-fill-mode-expected.txt View 1 chunk +12 lines, -12 lines 0 comments
M LayoutTests/animations/animation-direction-reverse-fill-mode-hardware.html View 2 chunks +4 lines, -4 lines 0 comments
M LayoutTests/animations/big-rotation.html View 1 chunk +3 lines, -3 lines 0 comments
M LayoutTests/animations/big-rotation-expected.txt View 1 chunk +3 lines, -3 lines 0 comments
M LayoutTests/animations/change-transform-style-during-animation.html View 1 chunk +2 lines, -2 lines 0 comments
M LayoutTests/animations/combo-transform-rotate+scale.html View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/animations/combo-transform-rotate+scale-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/animations/cross-fade-background-image.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-background-image-expected.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-border-image-source.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-border-image-source-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-list-style-image.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-list-style-image-expected.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-webkit-mask-box-image.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-webkit-mask-box-image-expected.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-webkit-mask-image.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/cross-fade-webkit-mask-image-expected.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/matrix-anim.html View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/animations/matrix-anim-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/animations/resources/animation-test-helpers.js View 6 chunks +87 lines, -399 lines 0 comments
M LayoutTests/animations/simultaneous-start-transform.html View 1 chunk +6 lines, -6 lines 0 comments
M LayoutTests/animations/simultaneous-start-transform-expected.txt View 1 chunk +6 lines, -6 lines 0 comments
M LayoutTests/animations/transition-and-animation-2.html View 1 chunk +3 lines, -2 lines 0 comments
M LayoutTests/animations/transition-and-animation-2-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation-from-none.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-from-none-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation-from-none-hw.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-from-none-hw-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation-from-none-multi.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-from-none-multi-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation-from-none-multi-hw.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-from-none-multi-hw-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation-hw.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-hw-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation-multi.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-multi-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/css3/filters/filter-animation-multi-hw.html View 4 chunks +5 lines, -5 lines 0 comments
M LayoutTests/css3/filters/filter-animation-multi-hw-expected.txt View 1 chunk +1 line, -1 line 0 comments
D LayoutTests/platform/linux/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
D LayoutTests/platform/mac-lion/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
D LayoutTests/platform/mac-lion/virtual/threaded/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
D LayoutTests/platform/mac/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
D LayoutTests/platform/mac/virtual/threaded/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
D LayoutTests/platform/win-xp/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
D LayoutTests/platform/win-xp/virtual/threaded/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
D LayoutTests/platform/win/transitions/svg-text-shadow-transition-expected.png View Binary file 0 comments
M LayoutTests/transitions/color-transition-premultiplied.html View 2 chunks +3 lines, -3 lines 0 comments
M LayoutTests/transitions/color-transition-premultiplied-expected.txt View 1 chunk +2 lines, -2 lines 0 comments
M LayoutTests/transitions/cross-fade-border-image.html View 2 chunks +7 lines, -2 lines 0 comments
M LayoutTests/transitions/cross-fade-border-image-expected.txt View 1 chunk +2 lines, -2 lines 0 comments
D LayoutTests/transitions/cubic-bezier-overflow-shadow.html View 1 chunk +0 lines, -52 lines 0 comments
D LayoutTests/transitions/cubic-bezier-overflow-shadow-expected.txt View 1 chunk +0 lines, -11 lines 0 comments
M LayoutTests/transitions/mismatched-shadow-styles.html View 1 chunk +4 lines, -4 lines 0 comments
M LayoutTests/transitions/mismatched-shadow-styles-expected.txt View 1 chunk +4 lines, -4 lines 0 comments
M LayoutTests/transitions/mismatched-shadow-transitions.html View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/transitions/mismatched-shadow-transitions-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/transitions/multiple-background-size-transitions.html View 1 chunk +2 lines, -2 lines 0 comments
M LayoutTests/transitions/multiple-background-size-transitions-expected.txt View 1 chunk +2 lines, -2 lines 0 comments
M LayoutTests/transitions/multiple-background-transitions.html View 1 chunk +3 lines, -3 lines 0 comments
M LayoutTests/transitions/multiple-background-transitions-expected.txt View 1 chunk +3 lines, -3 lines 0 comments
M LayoutTests/transitions/multiple-mask-transitions.html View 1 chunk +3 lines, -3 lines 0 comments
M LayoutTests/transitions/multiple-mask-transitions-expected.txt View 1 chunk +3 lines, -3 lines 0 comments
M LayoutTests/transitions/multiple-shadow-transitions.html View 1 chunk +3 lines, -3 lines 0 comments
M LayoutTests/transitions/multiple-shadow-transitions-expected.txt View 1 chunk +3 lines, -3 lines 0 comments
D LayoutTests/transitions/svg-text-shadow-transition.html View 1 chunk +0 lines, -45 lines 0 comments
D LayoutTests/transitions/svg-text-shadow-transition-expected.txt View 1 chunk +0 lines, -4 lines 0 comments
M LayoutTests/transitions/svg-transitions.html View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/transitions/svg-transitions-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/transitions/unanimatable-properties.html View 1 chunk +4 lines, -4 lines 0 comments
M LayoutTests/transitions/unanimatable-properties-expected.txt View 1 chunk +4 lines, -4 lines 0 comments
D LayoutTests/virtual/threaded/transitions/svg-transitions-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments

Messages

Total messages: 10 (4 generated)
Timothy Loh
https://codereview.chromium.org/716963002/diff/1/LayoutTests/transitions/cubic-bezier-overflow-shadow.html File LayoutTests/transitions/cubic-bezier-overflow-shadow.html (left): https://codereview.chromium.org/716963002/diff/1/LayoutTests/transitions/cubic-bezier-overflow-shadow.html#oldcode4 LayoutTests/transitions/cubic-bezier-overflow-shadow.html:4: <title>cubic-bezier value overflow: Shadows</title> I deleted this test since ...
6 years, 1 month ago (2014-11-11 23:49:05 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-12 02:48:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716963002/20001
6 years, 1 month ago (2014-11-12 02:49:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/19533)
6 years, 1 month ago (2014-11-12 02:54:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716963002/40001
6 years, 1 month ago (2014-11-12 02:55:31 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 05:35:55 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 185179

Powered by Google App Engine