Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 716873002: Use InputTypeNames more in MediaControlElements (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
Reviewers:
chrishtr, philipj_slow
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use InputTypeNames more in MediaControlElements Use existing AtomicStrings instead of a string literals that need to be converted to them. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M Source/core/html/shadow/MediaControlElements.cpp View 9 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL
6 years, 1 month ago (2014-11-11 20:08:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716873002/1
6 years, 1 month ago (2014-11-11 22:29:45 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-11 22:29:48 UTC) #6
chrishtr
lgtm
6 years, 1 month ago (2014-11-11 22:34:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716873002/1
6 years, 1 month ago (2014-11-11 22:34:43 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 23:47:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185154

Powered by Google App Engine
This is Rietveld 408576698