Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 716853003: Classes: Add support for arguments in default constructor (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Add support for arguments in default constructor This is currently done by generating a default constructor that looks like this: constructor() { %DefaultConstructorSuperCall(); } The a runtime function implements the logic which is pretty similar to Runtime_Apply except that it uses the [[Prototype]] of the current function. This is the second try. The first failed because the test was using a array that was too large for Function.prototype.apply. Revert "Revert "Classes: Add support for arguments in default constructor"" This reverts commit 43aa7e541df56a132608b8b4217e9da84575e4f8. BUG=v8:3672 LOG=Y TBR=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -11 lines) Patch
M src/parser.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-11 21:35:55 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25272 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698