Various clean-ups after top-level lexical declarations are done.

Various clean-ups after top-level lexical declarations are done.

1. Global{Context,Scope}=>Script{Context,Scope}
2. Enable fixed tests
3. Update comments

R=rossberg@chromium.org
BUG=v8:2198
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=25291

[Dmitry Lomov (no reviews), 2014-11-11 16:43:48]

PTAL, mostly mechanical changes.

[rossberg, 2014-11-12 09:49:28]

Like it, mostly nits.

https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc#newcode647
src/full-codegen.cc:647: // (innermost) enclosing script scope. To deal with
recursion, nested modules
Nit: can remove the "(innermost)"

https://codereview.chromium.org/716833002/diff/1/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/716833002/diff/1/src/globals.h#newcode654
src/globals.h:654: SCRIPT_SCOPE,    // The top-level scope for a program or a
top-level eval.
Nit: s/program/script/

https://codereview.chromium.org/716833002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/parser.cc#newcode910
src/parser.cc:910: *scope = Scope::DeserializeScopeChain(*info->context(),
*scope, zone());
Might be worth having an assertion after this:

  DCHECK(!(*scope)->is_script_scope());

https://codereview.chromium.org/716833002/diff/1/src/parser.cc#newcode1797
src/parser.cc:1797: // not a var (in the script scope, we also have to ignore
legacy const for
Nit: s/the script/a script/

https://codereview.chromium.org/716833002/diff/1/src/parser.cc#newcode1981
src/parser.cc:1981: // In ES6, a function behaves as a lexical binding, except
in the
Nit: s/except in the/except in a/

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-debug.cc...
src/runtime/runtime-debug.cc:1227: DCHECK(context_->IsNativeContext());
Note: this is all wrong and needs fixing, but that's for a separate CL.

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-scopes.c...
src/runtime/runtime-scopes.cc:200: // Declarations are always made in a
function, native, or script context. In
Hm, I wonder if this comment is accurate. I think it should drop "native", but
add "eval".

https://codereview.chromium.org/716833002/diff/1/src/scopes.cc
File src/scopes.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/scopes.cc#newcode733
src/scopes.cc:733: while (!scope->is_script_scope()) {
This loop should no longer be needed. (Is this method even needed?)

https://codereview.chromium.org/716833002/diff/1/src/scopes.h
File src/scopes.h (right):

https://codereview.chromium.org/716833002/diff/1/src/scopes.h#newcode399
src/scopes.h:399: // Find the innermost script scope.
Nit: remove "innermost". Do we actually still need this method?

[Dmitry Lomov (no reviews), 2014-11-12 10:16:27]

PTAL

https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc#newcode647
src/full-codegen.cc:647: // (innermost) enclosing script scope. To deal with
recursion, nested modules
On 2014/11/12 09:49:27, rossberg wrote:
> Nit: can remove the "(innermost)"

Done.

https://codereview.chromium.org/716833002/diff/1/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/716833002/diff/1/src/globals.h#newcode654
src/globals.h:654: SCRIPT_SCOPE,    // The top-level scope for a program or a
top-level eval.
On 2014/11/12 09:49:27, rossberg wrote:
> Nit: s/program/script/

Done.

https://codereview.chromium.org/716833002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/parser.cc#newcode910
src/parser.cc:910: *scope = Scope::DeserializeScopeChain(*info->context(),
*scope, zone());
On 2014/11/12 09:49:27, rossberg wrote:
> Might be worth having an assertion after this:
> 
>   DCHECK(!(*scope)->is_script_scope());

Done.

https://codereview.chromium.org/716833002/diff/1/src/parser.cc#newcode1797
src/parser.cc:1797: // not a var (in the script scope, we also have to ignore
legacy const for
On 2014/11/12 09:49:27, rossberg wrote:
> Nit: s/the script/a script/

Done.

https://codereview.chromium.org/716833002/diff/1/src/parser.cc#newcode1981
src/parser.cc:1981: // In ES6, a function behaves as a lexical binding, except
in the
On 2014/11/12 09:49:27, rossberg wrote:
> Nit: s/except in the/except in a/

Done.

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-debug.cc...
src/runtime/runtime-debug.cc:1227: DCHECK(context_->IsNativeContext());
On 2014/11/12 09:49:27, rossberg wrote:
> Note: this is all wrong and needs fixing, but that's for a separate CL.

Acknowledged.

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/runtime/runtime-scopes.c...
src/runtime/runtime-scopes.cc:200: // Declarations are always made in a
function, native, or script context. In
On 2014/11/12 09:49:27, rossberg wrote:
> Hm, I wonder if this comment is accurate. I think it should drop "native", but
> add "eval".

Done.

https://codereview.chromium.org/716833002/diff/1/src/scopes.cc
File src/scopes.cc (right):

https://codereview.chromium.org/716833002/diff/1/src/scopes.cc#newcode733
src/scopes.cc:733: while (!scope->is_script_scope()) {
On 2014/11/12 09:49:27, rossberg wrote:
> This loop should no longer be needed. (Is this method even needed?)
The loop is needed and the method is needed for modules

https://codereview.chromium.org/716833002/diff/1/src/scopes.h
File src/scopes.h (right):

https://codereview.chromium.org/716833002/diff/1/src/scopes.h#newcode399
src/scopes.h:399: // Find the innermost script scope.
On 2014/11/12 09:49:27, rossberg wrote:
> Nit: remove "innermost". Do we actually still need this method?
Done.
It is used in for modules.

[rossberg, 2014-11-12 10:49:26]

lgtm

[Dmitry Lomov (no reviews), 2014-11-12 10:59:56]

https://codereview.chromium.org/716833002/diff/20001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/716833002/diff/20001/src/parser.cc#newcode911
src/parser.cc:911: DCHECK(!(*scope)->is_script_scope());
As discussed offline, I'll land without this assertion and figure it out in a
separate CL

[Dmitry Lomov (no reviews), 2014-11-12 11:34:48]

Committed patchset #3 (id:40001) manually as 25291 (presubmit successful).