components/autofill/core/browser/autocomplete_history_manager.cc - Issue 71683003: Have AutofillManagerDelegate supply the AutofillWebDataService to core code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autocomplete_history_manager.cc

Issue 71683003: Have AutofillManagerDelegate supply the AutofillWebDataService to core code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/personal_data_manager_factory.cc ('K') | « components/autofill/core/browser/autocomplete_history_manager.h ('k') | components/autofill/core/browser/autocomplete_history_manager_unittest.cc » ('j') | components/autofill/core/browser/autofill_manager_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autocomplete_history_manager.cc

diff --git a/components/autofill/core/browser/autocomplete_history_manager.cc b/components/autofill/core/browser/autocomplete_history_manager.cc

index 2c3042764e87305290a529bb1655570e899676ea..7def322efadaea3ed0ac30e775db595e5112cfa4 100644

--- a/components/autofill/core/browser/autocomplete_history_manager.cc

+++ b/components/autofill/core/browser/autocomplete_history_manager.cc

@@ -16,11 +16,6 @@

#include "components/autofill/core/common/autofill_messages.h"

#include "components/autofill/core/common/autofill_pref_names.h"

#include "components/autofill/core/common/form_data.h"

-#include "content/public/browser/browser_context.h"

-#include "content/public/browser/web_contents.h"

-using content::BrowserContext;

-using content::WebContents;

namespace autofill {

namespace {

@@ -43,10 +38,8 @@ bool IsTextField(const FormFieldData& field) {

AutocompleteHistoryManager::AutocompleteHistoryManager(

AutofillDriver* driver,

AutofillManagerDelegate* manager_delegate)

- : browser_context_(driver->GetWebContents()->GetBrowserContext()),

- driver_(driver),

- autofill_data_(

- AutofillWebDataService::FromBrowserContext(browser_context_)),

+ : driver_(driver),

+ autofill_data_(manager_delegate->GetAutofillWebDataService()),

pending_query_handle_(0),

query_id_(0),

external_delegate_(NULL),