Referrer Policy: Update SanitizeForRequest with new default behavior.

Referrer Policy: Update SanitizeForRequest with new default behavior.

Currently, we'll crash when this method is called if a site sets
`NoReferrerWhenDowngrade`. That seems like something worth fixing. :)

-----------------------------------------------------------------------
Reland of https://crrev.com/3b0e841aa8b7d5ca5999f4340b8fa6f73305d3d2,
which was reverted due to compliation errors on the main waterfall.
-----------------------------------------------------------------------

BUG=431711
TBR=jochen@chromium.org

Committed: https://crrev.com/f4d08f1869ef410981af1f77dff237578cddd3ca
Cr-Commit-Position: refs/heads/master@{#303649}

[Mike West, 2014-11-11 13:58:41]

mkwst@chromium.org changed reviewers:
+ vabr@chromium.org

[Mike West, 2014-11-11 13:58:42]

Mind taking a look at this Vaclav? I suspect it's going to fix the compilation
errors on the athena bot. If it does, I'll carry over Jochen's lgtm from the
previous attempt.

Thanks!

-mike

[Mike West, 2014-11-11 14:10:26]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2014-11-11 14:10:44]

Yay. Athena compiled. :)

-mike

[vabr (Chromium), 2014-11-11 14:19:48]

Hi Mike.

To fix your problem, this LGTM. And it makes the code better than before.

Having said that, if this file was introduced as a new one, I would have more
objections:
(1) Referrer should be a class, not a struct
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Structs_vs._C...)
(2) The static method should be a const method and drop the second argument.

I don't think it's wise to address those in this CL, and I don't think they need
to be addressed by you. Just saying. :)

Cheers,
Vaclav

[vabr (Chromium), 2014-11-11 14:22:15]

On 2014/11/11 14:19:48, vabr (Chromium) wrote:
> Hi Mike.
> 
> To fix your problem, this LGTM. And it makes the code better than before.
> 
> Having said that, if this file was introduced as a new one, I would have more
> objections:
> (1) Referrer should be a class, not a struct
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Structs_vs._C...)
> (2) The static method should be a const method and drop the second argument.
> 
> I don't think it's wise to address those in this CL, and I don't think they
need
> to be addressed by you. Just saying. :)
> 
> Cheers,
> Vaclav

Also, if you want to be super nice to Jochen and other drive-by reviewers, you
can split the CL and do first the move to the .cc, and then the change you had
to revert. But no pressure, as the number of expected drive-bys is unclear. :)

Vaclav

[Mike West, 2014-11-11 14:22:16]

On 2014/11/11 14:19:48, vabr (Chromium) wrote:
> Hi Mike.
> 
> To fix your problem, this LGTM. And it makes the code better than before.
> 
> Having said that, if this file was introduced as a new one, I would have more
> objections:
> (1) Referrer should be a class, not a struct
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Structs_vs._C...)
> (2) The static method should be a const method and drop the second argument.
> 
> I don't think it's wise to address those in this CL, and I don't think they
need
> to be addressed by you. Just saying. :)
> 
> Cheers,
> Vaclav

I suspect you're right. I also suspect that you're right that it shouldn't block
this CL. :)

Thanks!

[Mike West, 2014-11-11 14:22:19]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-11-11 14:22:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/716813002/1

[Mike West, 2014-11-11 14:30:55]

> Also, if you want to be super nice to Jochen and other drive-by reviewers, you
> can split the CL and do first the move to the .cc, and then the change you had
> to revert. But no pressure, as the number of expected drive-bys is unclear. :)

Being nice is a) overrated, b) slow. Landing. :)

[commit-bot: I haz the power, 2014-11-11 15:11:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-11 15:11:45]

Patchset 1 (id:??) landed as
https://crrev.com/f4d08f1869ef410981af1f77dff237578cddd3ca
Cr-Commit-Position: refs/heads/master@{#303649}