Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 716793004: experimental (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove bad start in picture #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -36 lines) Patch
M include/core/SkCanvas.h View 3 chunks +6 lines, -1 line 0 comments Download
M samplecode/SampleArc.cpp View 1 3 chunks +53 lines, -35 lines 1 comment Download
M src/core/SkCanvas.cpp View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
reed1
does not yet compile :)
6 years, 1 month ago (2014-11-11 16:08:30 UTC) #2
reed1
now builds and runs, ptal
6 years, 1 month ago (2014-11-11 22:07:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716793004/20001
6 years, 1 month ago (2014-11-11 22:08:40 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-11 22:08:41 UTC) #7
mtklein
latest lgtm https://codereview.chromium.org/716793004/diff/20001/samplecode/SampleArc.cpp File samplecode/SampleArc.cpp (right): https://codereview.chromium.org/716793004/diff/20001/samplecode/SampleArc.cpp#newcode79 samplecode/SampleArc.cpp:79: MyDrawable* fDrawable; AutoTUnref?
6 years, 1 month ago (2014-11-12 03:34:42 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 03:36:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6a070dc06af4e9f305f9d08a69e34d18ade473cb

Powered by Google App Engine
This is Rietveld 408576698