Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 716793003: Don't print inlined function ID in --trace-hydrogen (Closed)

Created:
6 years, 1 month ago by wingo
Modified:
6 years, 1 month ago
CC:
v8-dev, Jakob Kummerow
Project:
v8
Visibility:
Public.

Description

Don't print inlined function ID in --trace-hydrogen FunctionLiteral has two purposes: it is a unit of compilation, and it is also an expression. Its id() is only for the latter purpose, used by the continuation of the closure, not by the closure itself. When we inline, we treat the FunctionLiteral as a unit of compilation, not as an expression, and as such the FunctionLiteral doesn't have any meaningful ID. The right thing to do is not to access the ID when printing the hydrogen expression. R=svenpanne@chromium.org, vegorov@google.com BUG=v8:3680 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=25267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wingo
6 years, 1 month ago (2014-11-11 14:20:25 UTC) #1
Sven Panne
LGTM from my side, but let's wait for Slava to see if it doesn't break ...
6 years, 1 month ago (2014-11-11 14:31:17 UTC) #3
Vyacheslav Egorov (Google)
LGTM, I don't think this is used in IRHydra [thanks for CCing me!]
6 years, 1 month ago (2014-11-11 14:32:30 UTC) #5
wingo
6 years, 1 month ago (2014-11-11 15:53:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698