Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 716793002: Remove V8.ZoneSegmentBytes. (Closed)

Created:
6 years, 1 month ago by marja
Modified:
6 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev, Sven Panne, dcarney
Project:
v8
Visibility:
Public.

Description

Remove V8.ZoneSegmentBytes. 1) It's unused. 2) Since Zones can be used on a background thread, the Zone cannot just access this counter from the Isolate, so keeping this counter up to date would require extra work. Better to just remove it. BUG=431860 LOG=n R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/zone-inl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
marja
yangguo, ptal
6 years, 1 month ago (2014-11-11 13:30:34 UTC) #2
Yang
On 2014/11/11 13:30:34, marja wrote: > yangguo, ptal lgtm.
6 years, 1 month ago (2014-11-11 13:34:16 UTC) #3
marja
Routing some offline (really offline) discussion. 1) So afawk, on the Chrome side counters should ...
6 years, 1 month ago (2014-11-11 14:26:12 UTC) #4
marja
6 years, 1 month ago (2014-11-11 14:27:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698