Source/core/html/HTMLSelectElement.idl - Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.idl

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added FIXME Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.idl

diff --git a/Source/core/html/HTMLSelectElement.idl b/Source/core/html/HTMLSelectElement.idl

index 1ad7706b91607dc56c7f4c0e869316b41348945f..0c4f6281a30329aaf4cab4f968d69d2e9f54077a 100644

--- a/Source/core/html/HTMLSelectElement.idl

+++ b/Source/core/html/HTMLSelectElement.idl

@@ -37,9 +37,8 @@ interface HTMLSelectElement : HTMLElement {

getter Element item(unsigned long index);

Element namedItem([Default=Undefined] optional DOMString name);

- // FIXME: should be union type http://crbug.com/240176

- [RaisesException, TypeChecking=Interface] void add(HTMLElement element, optional HTMLElement? before = null);

- [ImplementedAs=addBeforeOptionAtIndex, RaisesException, TypeChecking=Interface] void add(HTMLElement element, long before);

+ [RaisesException, TypeChecking=Interface] void add((HTMLOptionElement or HTMLOptGroupElement) element,

+ optional (HTMLElement or long)? before = null);

[RaisesException] void remove(); // ChildNode overload

void remove(long index);

[RaisesException, TypeChecking=Interface] setter HTMLOptionElement (unsigned long index, HTMLOptionElement? value);

« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | no next file » | no next file with comments »