Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLOptionsCollection.idl ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.h
diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h
index 988f9281aca0322fbe033660d51a3a40961c35f7..9e350d15acfcca1936a54b93fc630a99c167596c 100644
--- a/Source/core/html/HTMLSelectElement.h
+++ b/Source/core/html/HTMLSelectElement.h
@@ -37,6 +37,8 @@ namespace blink {
class AutoscrollController;
class ExceptionState;
class HTMLOptionElement;
+class HTMLOptionElementOrHTMLOptGroupElement;
+class HTMLElementOrLong;
class HTMLSelectElement final : public HTMLFormControlElementWithState, public TypeAheadDataSource {
DEFINE_WRAPPERTYPEINFO();
@@ -64,8 +66,7 @@ public:
bool usesMenuList() const;
- void add(HTMLElement*, HTMLElement* beforeElement, ExceptionState&);
- void addBeforeOptionAtIndex(HTMLElement*, int beforeIndex, ExceptionState&);
+ void add(const HTMLOptionElementOrHTMLOptGroupElement&, const HTMLElementOrLong&, ExceptionState&);
using Node::remove;
void remove(int index);
« no previous file with comments | « Source/core/html/HTMLOptionsCollection.idl ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698