LayoutTests/fast/js/select-options-add-expected.txt - Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments

Unified Diff: LayoutTests/fast/js/select-options-add-expected.txt

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added FIXME Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/js/script-tests/select-options-add.js ('k') | Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/select-options-add-expected.txt

diff --git a/LayoutTests/fast/js/select-options-add-expected.txt b/LayoutTests/fast/js/select-options-add-expected.txt

index e3d5b8e0b11f926b01dc781adf480be07e19a04c..a8290b5856722062dba581d3ab4a0e72bbf3ea0b 100644

--- a/LayoutTests/fast/js/select-options-add-expected.txt

+++ b/LayoutTests/fast/js/select-options-add-expected.txt

@@ -29,47 +29,47 @@ PASS select1.options[2].value is '3'

PASS select1.options[2].textContent is 'C'

1.4 Add a non-Option element

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.5 Add a non-element (string)

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.6 Add a non-element (number)

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.7 Add a non-element (boolean)

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.8 Add undefined

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.9 Add null

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.10 Add negative infinity

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.11 Add NaN

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

1.12 Add positive infinity

-PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The element provided was not an HTMLOptionElement..

+PASS select1.options.add(option1) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': Not a valid union member..

PASS select1.options.length is 3

PASS select1.selectedIndex is 0

@@ -158,68 +158,68 @@ PASS select2.options[6].value is '5'

PASS select2.options[6].textContent is 'E'

2.8 Add an Option at index -2

-PASS select2.options.add(option2, -2) threw exception IndexSizeError: Failed to execute 'add' on 'HTMLOptionsCollection': The index provided (-2) is less than -1..

-PASS select2.options.length is 7

+PASS select2.options.add(option2, -2) did not throw exception.

+PASS select2.options.length is 8

PASS select2.selectedIndex is 1

2.9 Add an Option at index -Infinity

PASS select2.options.add(option2, -1/0) did not throw exception.

-PASS select2.options.length is 8

+PASS select2.options.length is 9

PASS select2.selectedIndex is 2

2.10 Add an Option at index NaN

PASS select2.options.add(option2, 0/0) did not throw exception.

-PASS select2.options.length is 9

+PASS select2.options.length is 10

PASS select2.selectedIndex is 3

2.11 Add an Option at index Infinity

PASS select2.options.add(option2, 1/0) did not throw exception.

-PASS select2.options.length is 10