Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: LayoutTests/fast/dom/incompatible-operations-expected.txt

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/incompatible-operations-expected.txt
diff --git a/LayoutTests/fast/dom/incompatible-operations-expected.txt b/LayoutTests/fast/dom/incompatible-operations-expected.txt
index d95344f3f91645f3cc76bfee20c557278f8fd0c7..a3d4c72a242e6d8fe20a5f663bc7548bbb38a0e5 100644
--- a/LayoutTests/fast/dom/incompatible-operations-expected.txt
+++ b/LayoutTests/fast/dom/incompatible-operations-expected.txt
@@ -12,10 +12,10 @@ PASS aNode.isSameNode(void 0) is false
PASS aNode.lookupPrefix(aDOMImplementation) is null
PASS aNode.lookupPrefix(void 0) is null
PASS aNode.cloneNode(aDOMImplementation) instanceof HTMLDivElement is true
-PASS aSelect.add(aDOMImplementation, aDOMImplementation) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': parameter 1 is not of type 'HTMLElement'..
-PASS aSelect.add(aDOMImplementation, anOption) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': parameter 1 is not of type 'HTMLElement'..
-PASS aSelect.add(void 0, void 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': parameter 1 is not of type 'HTMLElement'..
-PASS aSelect.add(void 0, anOption) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': parameter 1 is not of type 'HTMLElement'..
+PASS aSelect.add(aDOMImplementation, aDOMImplementation) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
+PASS aSelect.add(aDOMImplementation, anOption) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
+PASS aSelect.add(void 0, void 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
+PASS aSelect.add(void 0, anOption) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
PASS aSelect.add(anOption, aDOMImplementation) is undefined.
PASS aSelect.add(anOption, void 0) is undefined.
PASS successfullyParsed is true

Powered by Google App Engine
This is Rietveld 408576698