Source/core/html/HTMLOptionsCollection.h - Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.h

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp ('k') | Source/core/html/HTMLOptionsCollection.cpp » ('j') | Source/core/html/HTMLSelectElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLOptionsCollection.h

diff --git a/Source/core/html/HTMLOptionsCollection.h b/Source/core/html/HTMLOptionsCollection.h

index 86a2c8c9e2841d8ec306a5f83907f4102738b5f1..a112371f0ecdde8d86c7a194589e65f55c0ac5d5 100644

--- a/Source/core/html/HTMLOptionsCollection.h

+++ b/Source/core/html/HTMLOptionsCollection.h

@@ -30,6 +30,8 @@

namespace blink {

class ExceptionState;

+class HTMLOptionElementOrHTMLOptGroupElement;

+class HTMLElementOrLong;

class NodeListOrElement;

class HTMLOptionsCollection final : public HTMLCollection {

@@ -39,8 +41,7 @@ public:

HTMLOptionElement* item(unsigned offset) const { return toHTMLOptionElement(HTMLCollection::item(offset)); }

- void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, ExceptionState&);

- void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, int index, ExceptionState&);

+ void add(const HTMLOptionElementOrHTMLOptGroupElement&, const HTMLElementOrLong&, ExceptionState&);

void remove(int index);

int selectedIndex() const;