Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: Source/core/html/HTMLOptionsCollection.h

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/scripts/v8_union.py ('k') | Source/core/html/HTMLOptionsCollection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 12 matching lines...) Expand all
23 23
24 #ifndef HTMLOptionsCollection_h 24 #ifndef HTMLOptionsCollection_h
25 #define HTMLOptionsCollection_h 25 #define HTMLOptionsCollection_h
26 26
27 #include "core/html/HTMLCollection.h" 27 #include "core/html/HTMLCollection.h"
28 #include "core/html/HTMLOptionElement.h" 28 #include "core/html/HTMLOptionElement.h"
29 29
30 namespace blink { 30 namespace blink {
31 31
32 class ExceptionState; 32 class ExceptionState;
33 class HTMLOptionElementOrHTMLOptGroupElement;
34 class HTMLElementOrLong;
33 class NodeListOrElement; 35 class NodeListOrElement;
34 36
35 class HTMLOptionsCollection final : public HTMLCollection { 37 class HTMLOptionsCollection final : public HTMLCollection {
36 DEFINE_WRAPPERTYPEINFO(); 38 DEFINE_WRAPPERTYPEINFO();
37 public: 39 public:
38 static PassRefPtrWillBeRawPtr<HTMLOptionsCollection> create(ContainerNode&, CollectionType); 40 static PassRefPtrWillBeRawPtr<HTMLOptionsCollection> create(ContainerNode&, CollectionType);
39 41
40 HTMLOptionElement* item(unsigned offset) const { return toHTMLOptionElement( HTMLCollection::item(offset)); } 42 HTMLOptionElement* item(unsigned offset) const { return toHTMLOptionElement( HTMLCollection::item(offset)); }
41 43
42 void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, ExceptionState&); 44 void add(const HTMLOptionElementOrHTMLOptGroupElement&, const HTMLElementOrL ong&, ExceptionState&);
43 void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, int index, ExceptionStat e&);
44 void remove(int index); 45 void remove(int index);
45 46
46 int selectedIndex() const; 47 int selectedIndex() const;
47 void setSelectedIndex(int); 48 void setSelectedIndex(int);
48 49
49 void setLength(unsigned, ExceptionState&); 50 void setLength(unsigned, ExceptionState&);
50 void namedGetter(const AtomicString& name, NodeListOrElement&); 51 void namedGetter(const AtomicString& name, NodeListOrElement&);
51 bool anonymousIndexedSetter(unsigned, PassRefPtrWillBeRawPtr<HTMLOptionEleme nt>, ExceptionState&); 52 bool anonymousIndexedSetter(unsigned, PassRefPtrWillBeRawPtr<HTMLOptionEleme nt>, ExceptionState&);
52 53
53 bool elementMatches(const HTMLElement&) const; 54 bool elementMatches(const HTMLElement&) const;
54 55
55 private: 56 private:
56 explicit HTMLOptionsCollection(ContainerNode&); 57 explicit HTMLOptionsCollection(ContainerNode&);
57 58
58 virtual void supportedPropertyNames(Vector<String>& names) override; 59 virtual void supportedPropertyNames(Vector<String>& names) override;
59 }; 60 };
60 61
61 DEFINE_TYPE_CASTS(HTMLOptionsCollection, LiveNodeListBase, collection, collectio n->type() == SelectOptions, collection.type() == SelectOptions); 62 DEFINE_TYPE_CASTS(HTMLOptionsCollection, LiveNodeListBase, collection, collectio n->type() == SelectOptions, collection.type() == SelectOptions);
62 63
63 inline bool HTMLOptionsCollection::elementMatches(const HTMLElement& element) co nst 64 inline bool HTMLOptionsCollection::elementMatches(const HTMLElement& element) co nst
64 { 65 {
65 return isHTMLOptionElement(element); 66 return isHTMLOptionElement(element);
66 } 67 }
67 68
68 } // namespace blink 69 } // namespace blink
69 70
70 #endif // HTMLOptionsCollection_h 71 #endif // HTMLOptionsCollection_h
OLDNEW
« no previous file with comments | « Source/bindings/scripts/v8_union.py ('k') | Source/core/html/HTMLOptionsCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698