Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 716763002: Revert "Revert of Implement getPermissionStatus in MockWebPushClient" (Closed)

Created:
6 years, 1 month ago by Miguel Garcia
Modified:
6 years, 1 month ago
Reviewers:
tkent
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, wjia+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Implement getPermissionStatus in MockWebPushClient" (patchset #3 id:40001 of https://codereview.chromium.org/677073002/) This reverts commit 62bb47df51eac10a618b9ad5e4b15d2bae8ab6d6. It was originally reverted because it broke one layout test in blink. The problem with the layout test was in blink itself and fixed in https://codereview.chromium.org/709733003/ so I am now relading this. BUG=401424 TBR=tkent Committed: https://crrev.com/7976e136c2a7a929e5e01f4d036455dc4b2f4c58 Cr-Commit-Position: refs/heads/master@{#303634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M content/shell/renderer/test_runner/mock_web_push_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_push_client.cc View 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716763002/1
6 years, 1 month ago (2014-11-11 12:12:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 13:15:13 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 13:15:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7976e136c2a7a929e5e01f4d036455dc4b2f4c58
Cr-Commit-Position: refs/heads/master@{#303634}

Powered by Google App Engine
This is Rietveld 408576698