Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1920)

Unified Diff: Source/web/WebKit.cpp

Issue 716723003: Script streaming: Shutdown streaming before V8. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/Init.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebKit.cpp
diff --git a/Source/web/WebKit.cpp b/Source/web/WebKit.cpp
index b36a3078f878ea1502cbebdd16f22c44f71fffe1..476b3c9fc3e4851f4691ee9d78e28d20a1694130 100644
--- a/Source/web/WebKit.cpp
+++ b/Source/web/WebKit.cpp
@@ -31,6 +31,7 @@
#include "config.h"
#include "public/web/WebKit.h"
+#include "bindings/core/v8/ScriptStreamerThread.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8GCController.h"
#include "bindings/core/v8/V8Initializer.h"
@@ -204,6 +205,10 @@ void shutdown()
s_messageLoopInterruptor = 0;
}
+ // Shutdown V8-related background threads before V8 is ramped down. Note
+ // that this will wait the thread to stop its operations.
+ ScriptStreamerThread::shutdown();
+
v8::Isolate* isolate = V8PerIsolateData::mainThreadIsolate();
V8PerIsolateData::willBeDestroyed(isolate);
« no previous file with comments | « Source/core/Init.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698