Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 716723003: Script streaming: Shutdown streaming before V8. (Closed)

Created:
6 years, 1 month ago by marja
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Script streaming: Shutdown streaming before V8. We should wait for the V8 side operations to complete *before* tearing down the Isolate. BUG=431860 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M Source/core/Init.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/web/WebKit.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
marja
haraken, ptal
6 years, 1 month ago (2014-11-11 14:31:56 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-11 14:49:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716723003/1
6 years, 1 month ago (2014-11-11 14:53:37 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 16:45:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185131

Powered by Google App Engine
This is Rietveld 408576698