Migrating test/ppapi_file_system to messaging

Migrating test/ppapi_file_system to messaging
Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5682

[David Springer, 2011-06-15 21:40:27]

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_file_system/ppap...
File tests/ppapi_file_system/ppapi_file_system.cc (right):

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_file_system/ppap...
tests/ppapi_file_system/ppapi_file_system.cc:181: printf("WHAAAAAAA?!?!?!\n");
Are you sure that this is useful test output?

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_file_system/ppap...
tests/ppapi_file_system/ppapi_file_system.cc:184: const struct PPB_Core* const
ppb_core = PPBCore();
It seems like this code inside the #else clause should be enabled, instead of
the, er, debug output above?

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/get_bro...
File tests/ppapi_test_lib/get_browser_interface.h (right):

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/get_bro...
tests/ppapi_test_lib/get_browser_interface.h:54: const PPB_FileSystem_Dev*
PPBFileSystemDev();
I thought these were supposed to be added in the individual test code, and not
added here?  Did I get that wrong?

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/test_in...
File tests/ppapi_test_lib/test_interface.h (right):

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/test_in...
tests/ppapi_test_lib/test_interface.h:58: #include <stdio.h>
This seems unused - remove?

[Sang Ahn, 2011-06-15 22:27:42]

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_file_system/ppap...
File tests/ppapi_file_system/ppapi_file_system.cc (right):

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_file_system/ppap...
tests/ppapi_file_system/ppapi_file_system.cc:181: printf("WHAAAAAAA?!?!?!\n");
That's too funny.

On 2011/06/15 21:40:27, David Springer wrote:
> Are you sure that this is useful test output?

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_file_system/ppap...
tests/ppapi_file_system/ppapi_file_system.cc:184: const struct PPB_Core* const
ppb_core = PPBCore();
On 2011/06/15 21:40:27, David Springer wrote:
> It seems like this code inside the #else clause should be enabled, instead of
> the, er, debug output above?

Done.

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/get_bro...
File tests/ppapi_test_lib/get_browser_interface.h (right):

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/get_bro...
tests/ppapi_test_lib/get_browser_interface.h:54: const PPB_FileSystem_Dev*
PPBFileSystemDev();
I didn't now that.  I put that here since the reference to the browser interface
getter is in the test lib.
On 2011/06/15 21:40:27, David Springer wrote:
> I thought these were supposed to be added in the individual test code, and not
> added here?  Did I get that wrong?

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/test_in...
File tests/ppapi_test_lib/test_interface.h (right):

http://codereview.chromium.org/7167018/diff/3002/tests/ppapi_test_lib/test_in...
tests/ppapi_test_lib/test_interface.h:58: #include <stdio.h>
It's used by the EXPECT* macros below.

On 2011/06/15 21:40:27, David Springer wrote:
> This seems unused - remove?

[David Springer, 2011-06-15 22:56:30]

LGTM.