Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: Source/core/html/shadow/MediaControlElements.cpp

Issue 716613002: Use different icons for the overlay and non-overlay cast buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/MediaControlElements.cpp
diff --git a/Source/core/html/shadow/MediaControlElements.cpp b/Source/core/html/shadow/MediaControlElements.cpp
index ecf407457684f156fd0e13da09c8e0dd43139111..ce0549b97f142a7aa9cb6543c52fbd18e0386b09 100644
--- a/Source/core/html/shadow/MediaControlElements.cpp
+++ b/Source/core/html/shadow/MediaControlElements.cpp
@@ -570,6 +570,7 @@ void MediaControlFullscreenButtonElement::setIsFullscreen(bool isFullscreen)
MediaControlCastButtonElement::MediaControlCastButtonElement(MediaControls& mediaControls, bool isOverlayButton)
: MediaControlInputElement(mediaControls, MediaCastOnButton), m_isOverlayButton(isOverlayButton)
{
+ setIsPlayingRemotely(false);
}
PassRefPtrWillBeRawPtr<MediaControlCastButtonElement> MediaControlCastButtonElement::create(MediaControls& mediaControls, bool isOverlayButton)
@@ -601,7 +602,19 @@ const AtomicString& MediaControlCastButtonElement::shadowPseudoId() const
void MediaControlCastButtonElement::setIsPlayingRemotely(bool isPlayingRemotely)
{
- setDisplayType(isPlayingRemotely ? MediaCastOnButton : MediaCastOffButton);
+ if (isPlayingRemotely) {
+ if (m_isOverlayButton) {
+ setDisplayType(MediaOverlayCastOnButton);
+ } else {
+ setDisplayType(MediaCastOnButton);
+ }
+ } else {
+ if (m_isOverlayButton) {
+ setDisplayType(MediaOverlayCastOffButton);
+ } else {
+ setDisplayType(MediaCastOffButton);
+ }
+ }
}
bool MediaControlCastButtonElement::keepEventInNode(Event* event)

Powered by Google App Engine
This is Rietveld 408576698