Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 716603002: Use ContainerNode more in DOMEditor (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use ContainerNode more in DOMEditor Use ContainerNode more in DOMEditor, specifically this allows us to call replaceChild/removeChild etc. on ContainerNode directly, skipping the checks in Node::replaceChild/removeChild. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M Source/core/inspector/DOMEditor.h View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 10 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
rwlbuis
PTAL
6 years, 1 month ago (2014-11-10 20:28:09 UTC) #2
pfeldman
lgtm
6 years, 1 month ago (2014-11-11 10:11:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716603002/1
6 years, 1 month ago (2014-11-11 12:07:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/30313)
6 years, 1 month ago (2014-11-11 13:22:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716603002/1
6 years, 1 month ago (2014-11-11 14:57:33 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 15:34:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185126

Powered by Google App Engine
This is Rietveld 408576698