Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 716463002: Revert "MacViews: Get chrome/browser/ui/views/frame to compile" (Closed)

Created:
6 years, 1 month ago by raymes
Modified:
6 years, 1 month ago
Reviewers:
tapted, Andre
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "MacViews: Get chrome/browser/ui/views/frame to compile" This reverts commit f6158b090dc352608141ba8a9d8f09bbdbf4af88. Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608 NOTREECHECKS=true NOTRY=true BUG=431608 TBR=tapted@chromium.org,andresantoso@chromium.org Committed: https://crrev.com/8bdca01518ca8f1443d5255adab9ebfa607c7850 Cr-Commit-Position: refs/heads/master@{#303411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -330 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
A + chrome/browser/ui/cocoa/browser_window_factory.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/ui/cocoa/browser_window_factory_cocoa.mm View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_command_handler_x11.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_command_handler_x11.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 7 chunks +59 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_ash.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_ash.cc View 3 chunks +7 lines, -11 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_mac.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_mac.mm View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 7 chunks +26 lines, -10 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_window_factory.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_web_view.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 3 chunks +6 lines, -40 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller.h View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 3 chunks +2 lines, -14 lines 0 comments Download
A + chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/frame/immersive_mode_controller_factory_ash.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/views/frame/immersive_mode_controller_factory_mac.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/frame/native_browser_frame.h View 2 chunks +2 lines, -3 lines 0 comments Download
D chrome/browser/ui/views/frame/native_browser_frame_factory_mac.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 6 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716463002/1
6 years, 1 month ago (2014-11-10 01:10:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 01:11:15 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 01:11:49 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8bdca01518ca8f1443d5255adab9ebfa607c7850
Cr-Commit-Position: refs/heads/master@{#303411}

Powered by Google App Engine
This is Rietveld 408576698