components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java - Issue 716433003: Continue impementation SessionDependencyFactoryNative.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java

Issue 716433003: Continue impementation SessionDependencyFactoryNative. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native-factory

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_bridge/test/android/javatests/jni/jni_onload.cc ('k') | components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/GCDClientSessionTestingHost.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java

diff --git a/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java b/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java

index b719ed9735e001b2c5d85e1d2ac3954d55c50afa..3c82610c07579d0497a4d537beb17e2093e526a4 100644

--- a/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java

+++ b/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java

@@ -77,7 +77,7 @@ public class DevToolsBridgeServerSandbox {

private void createConnections() {

assert mClientSession1 == null;

assert mClientSession2 == null;

- mFactory = new SessionDependencyFactory();

+ mFactory = SessionDependencyFactory.newInstance();

String pid = Integer.toString(Process.myPid());

try {

@@ -98,12 +98,12 @@ public class DevToolsBridgeServerSandbox {

}

private void stopInternal() {

- Log.d(TAG, "Service disconnected. Stopping client sessions");

- mClientSession1.dispose();

- mClientSession2.dispose();

- mFactory.dispose();

- mClientSession1 = null;

- mClientSession2 = null;

- mFactory = null;

+ Log.d(TAG, "Service disconnected. Stopping client sessions");

+ mClientSession1.dispose();

+ mClientSession2.dispose();

+ mFactory.dispose();

+ mClientSession1 = null;

+ mClientSession2 = null;

+ mFactory = null;

}