File src/scanner.cc (right):
src/scanner.cc:83: if (x > max_value) return -1;
On 2014/11/13 15:09:18, caitp wrote:
> I don't think this should block landing this, but I think it would be an
> improvement if this error condition were handled in the parser, so that an
> could be reported (like "SyntaxError: Unicode escape sequences cannot have a
> value exceeding U+10FFFF" or something).
> So you'd want to make sure the value doesn't overflow, but max_value checking
> could be verified in the parser. Again though, not a blocker, I just think
> would be easier on people. SpiderMonkey outputs some pretty nice static errors
> for a lot of these, but V8 is just saying "Unexpected token ____" which is not
> that great.
> Not a blocker but something to think about
Alternatively, we should enable the scanner to give proper error messages.
Issue 716423002: ES6 unicode extensions, part 1.
Created 6 years, 1 month ago by marja
Modified 6 years ago
Reviewers: arv (Not doing code reviews), rossberg, caitp (gmail), mathias
Base URL: https://chromium.googlesource.com/v8/v8.git@master