Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 716413003: Fix build for iOS after "Make nanobench and dm be usable from Chromium build" (Closed)

Created:
6 years, 1 month ago by Kimmo Kinnunen
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix build for iOS after "Make nanobench and dm be usable from Chromium build" Fix build for iOS after "Make nanobench and dm be usable from Chromium build" BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/0935aed2787eb79629125bdfef9aba2a6a283ef7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/iOSShell.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Kimmo Kinnunen
This should fix the build breakage
6 years, 1 month ago (2014-11-13 13:15:22 UTC) #2
Kimmo Kinnunen
Robert, sorry to bother you, but adding you since you seem to be working already. ...
6 years, 1 month ago (2014-11-13 13:27:32 UTC) #4
robertphillips
lgtm
6 years, 1 month ago (2014-11-13 13:49:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716413003/1
6 years, 1 month ago (2014-11-13 13:53:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0935aed2787eb79629125bdfef9aba2a6a283ef7
6 years, 1 month ago (2014-11-13 14:00:50 UTC) #8
jcgregorio
On 2014/11/13 14:00:50, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 1 month ago (2014-11-13 15:08:55 UTC) #9
jcgregorio
6 years, 1 month ago (2014-11-13 15:56:15 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/724813002/ by jcgregorio@google.com.

The reason for reverting is: Causes breakages on Mac..

Powered by Google App Engine
This is Rietveld 408576698