Issue 716413002: Sync cld_2.gyp with cld_2/BUILD.GN, make BUILD.gn authoritative.

Issue 716413002: Sync cld_2.gyp with cld_2/BUILD.GN, make BUILD.gn authoritative. (Closed)

Created:
6 years, 1 month ago by Andrew Hayden (chromium.org)

Modified:
6 years, 1 month ago

Reviewers:
Dirk Pranke, brettw

CC:
chromium-reviews, Takashi Toyoshima, hajimehoshi, picksi1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Sync cld_2.gyp with cld_2/BUILD.GN, make BUILD.gn authoritative. Also removes a comment that is no longer applicable in common.gypi. BUG= TBR=toyoshim@chromium.org Committed: https://crrev.com/7c3b1854c5f8ae7e929c6822fa20e780b668f020 Cr-Commit-Position: refs/heads/master@{#304013}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -125 lines)			Patch
M	build/common.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/cld_2/BUILD.gn	View		4 chunks	+42 lines, -71 lines	0 comments	Download
M	third_party/cld_2/cld_2.gyp	View	1	8 chunks	+53 lines, -53 lines	0 comments	Download

Total messages: 7 (2 generated)

Andrew Hayden (chromium.org)

Added folks to CC and reviewers from https://codereview.chromium.org/718943002 This is a structure change that should ...

6 years, 1 month ago (2014-11-13 10:18:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716413002/20001

6 years, 1 month ago (2014-11-13 10:19:15 UTC) #4

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/7c3b1854c5f8ae7e929c6822fa20e780b668f020 Cr-Commit-Position: refs/heads/master@{#304013}

6 years, 1 month ago (2014-11-13 11:25:06 UTC) #6

Message was sent while issue was closed.

lgtm