Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: Source/devtools/front_end/inspector.js

Issue 71633003: DevTools: added "overlayContents" mode, where DevTools content is placed around and underneath inse… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No-op if no overlayContents Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/inspector.js
diff --git a/Source/devtools/front_end/inspector.js b/Source/devtools/front_end/inspector.js
index 53783037d6e1f424265cb7192566a0b98ccf8dfd..3710061693fe622ed9ebd90429f24fd8921989c7 100644
--- a/Source/devtools/front_end/inspector.js
+++ b/Source/devtools/front_end/inspector.js
@@ -67,7 +67,7 @@ var WebInspector = {
}
this.inspectorView.appendToRightToolbar(this.settingsController.statusBarItem);
- if (!WebInspector.queryParamsObject["remoteFrontend"])
+ if (!WebInspector.queryParamsObject["remoteFrontend"] && !WebInspector.WorkerManager.isWorkerFrontend())
pfeldman 2013/12/05 15:44:06 We need to handle even more cases, not sure you ne
this.inspectorView.appendToRightToolbar(this.dockController.element);
var closeButtonToolbarItem = document.createElementWithClass("div", "toolbar-close-button-item");
@@ -84,6 +84,17 @@ var WebInspector = {
return !!WebInspector.queryParamsObject["remoteFrontend"];
},
+ /**
+ * @return {boolean}
+ */
+ useOverlayContentsLayout: function()
+ {
+ var docked = WebInspector.queryParamsObject["dockSide"] !== WebInspector.DockController.State.Undocked;
+ if (WebInspector.dockController)
+ docked = WebInspector.dockController.dockSide() !== WebInspector.DockController.State.Undocked;
+ return docked && !!WebInspector.queryParamsObject["overlayContents"];
pfeldman 2013/12/05 15:44:06 I think you only want this bit here: return !!Web
dgozman 2013/12/06 16:17:13 Done.
+ },
+
_toggleScreencastButtonClicked: function()
{
this._toggleScreencastButton.toggled = !this._toggleScreencastButton.toggled;
@@ -334,6 +345,8 @@ WebInspector.doLoadedDone = function()
WebInspector.installPortStyles();
if (WebInspector.socket)
document.body.addStyleClass("remote");
+ if (WebInspector.queryParamsObject["overlayContents"])
+ document.body.addStyleClass("overlay-contents");
if (WebInspector.queryParamsObject.toolbarColor && WebInspector.queryParamsObject.textColor)
WebInspector.setToolbarColors(WebInspector.queryParamsObject.toolbarColor, WebInspector.queryParamsObject.textColor);

Powered by Google App Engine
This is Rietveld 408576698