DevTools: added "overlayContents" mode, where DevTools content is placed around and underneath inse…

Source/devtools/front_end/inspector.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 49 matching lines @@
         if (this.inspectElementModeController)
             this.inspectorView.appendToLeftToolbar(this.inspectElementModeController.toggleSearchButton.element);
 
         if (Capabilities.canScreencast) {
             this._toggleScreencastButton = new WebInspector.StatusBarButton(WebInspector.UIString("Toggle screencast."), "screencast-status-bar-item");
             this._toggleScreencastButton.addEventListener("click", this._toggleScreencastButtonClicked.bind(this), false);
             this.inspectorView.appendToLeftToolbar(this._toggleScreencastButton.element);
         }
 
         this.inspectorView.appendToRightToolbar(this.settingsController.statusBarItem);
-        if (!WebInspector.queryParamsObject["remoteFrontend"])
+        if (!WebInspector.queryParamsObject["remoteFrontend"] && !WebInspector.WorkerManager.isWorkerFrontend())

[pfeldman, 2013/12/05 15:44:06]

We need to handle even more cases, not sure you need it here.

             this.inspectorView.appendToRightToolbar(this.dockController.element);
 
         var closeButtonToolbarItem = document.createElementWithClass("div", "toolbar-close-button-item");
         var closeButtonElement = closeButtonToolbarItem.createChild("div", "close-button");
         closeButtonElement.addEventListener("click", WebInspector.close.bind(WebInspector), true);
         this.inspectorView.appendToRightToolbar(closeButtonToolbarItem);
     },
 
     /**
      * @return {boolean}
      */
     isInspectingDevice: function()
     {
         return !!WebInspector.queryParamsObject["remoteFrontend"];
     },
 
+    /**
+     * @return {boolean}
+     */
+    useOverlayContentsLayout: function()
+    {
+        var docked = WebInspector.queryParamsObject["dockSide"] !== WebInspector.DockController.State.Undocked;
+        if (WebInspector.dockController)
+            docked = WebInspector.dockController.dockSide() !== WebInspector.DockController.State.Undocked;
+        return docked && !!WebInspector.queryParamsObject["overlayContents"];

[pfeldman, 2013/12/05 15:44:06]

I think you only want this bit here:

return !!WebInspector.queryParamsObject["overlayContents"];

In fact, you could check it in-place.

[dgozman, 2013/12/06 16:17:13]

Done.

+    },
+
     _toggleScreencastButtonClicked: function()
     {
         this._toggleScreencastButton.toggled = !this._toggleScreencastButton.toggled;
         WebInspector.settings.screencastEnabled.set(this._toggleScreencastButton.toggled);
 
         if (this._toggleScreencastButton.toggled) {
             if (!this._screencastView) {
                 // Rebuild the UI upon first invocation.
                 this._screencastView = new WebInspector.ScreencastView();
                 this._screencastSplitView = new WebInspector.SplitView(true, WebInspector.settings.screencastSidebarWidth.name);
@@ skipping 230 matching lines @@
         WebInspector._doLoadedDoneWithCapabilities();
     }
 }
 
 WebInspector.doLoadedDone = function()
 {
     // Install styles and themes
     WebInspector.installPortStyles();
     if (WebInspector.socket)
         document.body.addStyleClass("remote");
+    if (WebInspector.queryParamsObject["overlayContents"])
+        document.body.addStyleClass("overlay-contents");
 
     if (WebInspector.queryParamsObject.toolbarColor && WebInspector.queryParamsObject.textColor)
         WebInspector.setToolbarColors(WebInspector.queryParamsObject.toolbarColor, WebInspector.queryParamsObject.textColor);
 
     WebInspector.WorkerManager.loaded();
 
     PageAgent.canScreencast(WebInspector._initializeCapability.bind(WebInspector, "canScreencast", null));
     WorkerAgent.canInspectWorkers(WebInspector._initializeCapability.bind(WebInspector, "canInspectWorkers", WebInspector._doLoadedDoneWithCapabilities.bind(WebInspector)));
 }
 
@@ skipping 664 matching lines @@
 
 /**
  * @return {string}
  */
 WebInspector.getSelectionForegroundColor = function()
 {
     return InspectorFrontendHost.getSelectionForegroundColor();
 }
 
 window.DEBUG = true;